Closed
Conversation
<strstream> is deprecated since C++98 and removed in C++26 (P2867R1). Replace std::istrstream/std::ostrstream with std::istringstream/ std::ostringstream in the porthopper protocol example. For writing, use std::ostringstream then memcpy to the fixed buffer since ostringstream manages its own string storage unlike ostrstream. Fixes #1725
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated
<strstream>header with<sstream>in the C++11 porthopper example.<strstream>has been deprecated since C++98 and is removed in C++26 per P2867R1.Changes
src/examples/cpp11/porthopper/protocol.hpp:#include <strstream>->#include <sstream>std::istrstream(data_, size)->std::istringstream(std::string(data_, size))std::ostrstream(data_, size)->std::ostringstream+std::memcpyto copy the result back to the fixed bufferThe
ostrstream->ostringstreamconversion requires an extra copy step sinceostrstreamwrites directly to a providedchar[]buffer whileostringstreammanages its own internal string.Fixes #1725