Compile fix for Visual C++ Update 3 - #22
Closed
MarcelRaad wants to merge 4 commits into
Closed
MarcelRaad wants to merge 4 commits into
MarcelRaad wants to merge 4 commits into
Conversation
Starting with Visual C++ Update 3 RC, WSAAddressToStringA is deprecated. This leads to a compiler warning which is treated as an error with the /sdl switch (which is enabled by default for new projects): error C4996: 'WSAAddressToStringA': Use WSAAddressToStringW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings This change calls WSAAddressToStringW instead of WSAAddressToStringA for Visual C++ 2013 and later.
inet_addr is also deprecated, replaced by socket_ops::inet_pton.
Owner
|
Perhaps this should be reported to MS? I didn't think service packs were supposed to break previously valid code. |
Contributor
Author
|
Of course you're right. Unfortunately the breakage is actually in the updated Windows SDK and everything I've ever seen reported on Microsoft Connect about the Windows SDK got immediately closed as "external", so I have no idea where to report this. |
Owner
|
Fixed in 3389cb9. |
VemundH
added a commit
to VemundH/asio
that referenced
this pull request
Sep 7, 2014
This is basically the same issue as fixed in pull request chriskohlhoff#22. WSASocket resolves to WSASocketA unless UNICODE is defined. This is the case when building the boost source. I think using the W version should be OK (the LPWSAPROTOCOL_INFO argument is null).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Visual C++ Update 3 RC, WSAAddressToStringA and gethostbyaddr are deprecated.
This leads to compiler warnings which are treated as an error with the /sdl switch (which is enabled by default for new projects):
error C4996: 'WSAAddressToStringA': Use WSAAddressToStringW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings
error C4996: 'gethostbyaddr': Use getnameinfo() or GetNameInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings
This change calls WSAAddressToStringW instead of WSAAddressToStringA for Visual C++ 2013 and later.