Conversation
Author
|
The best solution for solving (3) is probably to add something like: to the socket "protocol_type" classes. This is kind of a design decision that should be approved before making changes to the code. |
Owner
|
Addressed using a different approach in 9fc74ea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async_accept was used as motivation. (E.g. win_iocp_socket_connect_op is based on win_iocp_socket_accept_op)
Implementation details/considerations:
The code will fall back on using the reactor implementation if the code targets and earlier version of Windows than XP, the socket is not connection-oriented or in case of failure to obtain the ConnectEx function pointer.
A version without the “optimization” in (2) is available in this commit: VemundH@f89c15a