Skip to content

[1.5] Add support for XPath by introducing Selector and Mouse::findElement() - #340

Merged
GrahamCampbell merged 1 commit into
chrome-php:1.5from
simPod:xpath
Mar 25, 2022
Merged

[1.5] Add support for XPath by introducing Selector and Mouse::findElement()#340
GrahamCampbell merged 1 commit into
chrome-php:1.5from
simPod:xpath

Conversation

@simPod

@simPodsimPod commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Resolves#333

@simPod
simPodforce-pushed the xpath branch 4 times, most recently from aac9517 to f89ebbeCompareJanuary 31, 2022 09:21
@simPod
simPod marked this pull request as ready for review January 31, 2022 09:22
enricodias
enricodias reviewed Jan 31, 2022
View reviewed changes
Comment threadsrc/Dom/Selector/Selector.php
enricodias
enricodias reviewed Jan 31, 2022
View reviewed changes
Comment threadsrc/Input/Mouse.php
@enricodias

enricodias commented Jan 31, 2022

Copy link
Copy Markdown
Member

Do you think it's worth it to have a test class for each Selector class separately? Even thought they are still being tested indirectly in the mouse tests.

@simPod

simPod commented Jan 31, 2022

Copy link
Copy Markdown
ContributorAuthor

Do you think it's worth it to have a test class for each Selector class separately? Even thought they are still being tested indirectly in the mouse tests.

It discovered few bugs related to position when I deved it.

@GrahamCampbell
GrahamCampbell changed the base branch from 1.4 to 1.5February 1, 2022 14:35
@simPod

simPod commented Mar 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Do we want to pursue this?

@enricodias

enricodias commented Mar 3, 2022

Copy link
Copy Markdown
Member

I think so.

@simPod

simPod commented Mar 3, 2022

Copy link
Copy Markdown
ContributorAuthor

I have rebased on 1.5 since there was a force push I guess

@simPod

simPod commented Mar 3, 2022

Copy link
Copy Markdown
ContributorAuthor

The scrolling tests in GA are flaky (see https://github.com/simPod/chrome/runs/5407170225)

@enricodias

enricodias commented Mar 3, 2022

Copy link
Copy Markdown
Member

Yes, they are. But I never managed to reproduce this error locally :/

@simPod

simPod commented Mar 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Yes, they are. But I never managed to reproduce this error locally :/

yup, same here

@GrahamCampbellGrahamCampbell changed the title Add support for XPath by introducing Selector and Mouse::findElement()[1.5] Add support for XPath by introducing Selector and Mouse::findElement()Mar 24, 2022
GrahamCampbell
GrahamCampbell requested changes Mar 24, 2022
View reviewed changes

@GrahamCampbellGrahamCampbell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to resolve the merge conflicts, please?

@simPod
simPodforce-pushed the xpath branch 2 times, most recently from 30e9209 to 401408aCompareMarch 25, 2022 07:37
@GrahamCampbellGrahamCampbell changed the title [1.5] Add support for XPath by introducing Selector and Mouse::findElement()Add support for XPath by introducing Selector and Mouse::findElement()Mar 25, 2022
@GrahamCampbell
GrahamCampbell merged commit 8b6c4dc into chrome-php:1.5Mar 25, 2022
@simPod
simPod deleted the xpath branch March 25, 2022 08:51
@GrahamCampbellGrahamCampbell changed the title Add support for XPath by introducing Selector and Mouse::findElement()[1.5Add support for XPath by introducing Selector and Mouse::findElement()Aug 28, 2022
@GrahamCampbellGrahamCampbell changed the title [1.5Add support for XPath by introducing Selector and Mouse::findElement()[1.5] Add support for XPath by introducing Selector and Mouse::findElement()Aug 28, 2022
@GrahamCampbellGrahamCampbell mentioned this pull request Dec 13, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enricodiasenricodiasenricodias approved these changes
@GrahamCampbellGrahamCampbellAwaiting requested review from GrahamCampbell

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Xpath support

3 participants

@simPod@enricodias@GrahamCampbell