Skip to content

Added SEAL library and FHE mode - #41

Open
Northrim wants to merge 27 commits into
masterfrom
fhe
Open

Added SEAL library and FHE mode#41
Northrim wants to merge 27 commits into
masterfrom
fhe

Conversation

@Northrim

@NorthrimNorthrim commented Jan 10, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@Northrim
Northrim requested review from alex-ozdemir and edwjchen and removed request for alex-ozdemirJanuary 10, 2022 21:29
alex-ozdemir
alex-ozdemir requested changes Jan 10, 2022
View reviewed changes

@alex-ozdemiralex-ozdemir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, William. I have a few suggestions within.

Comment thread.gitmodules Outdated
Comment threadsrc/front/zokrates/mod.rs Outdated
Comment threadexamples/circ.rs Outdated
alex-ozdemir
alex-ozdemir reviewed Mar 25, 2022
View reviewed changes

@alex-ozdemiralex-ozdemir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions...

Comment thread.vscode/settings.json
Comment threadthird_party/SEAL_templates/cpp_template.txt Outdated
Comment threadsrc/target/fhe/utils.rs Outdated
Comment threadscripts/fhe_tests/tests/fhe_and_zok_bytecode.txt Outdated
edwjchen
edwjchen requested changes Mar 31, 2022
View reviewed changes
Comment threaddriver.py Outdated
Comment threadscripts/build_fhe_c_test.zsh Outdated
Comment threadscripts/build_fhe_zokrates_test.zsh Outdated
Comment threadscripts/seal_tests/c_test_seal.py Outdated
Comment threadscripts/seal_tests/c_test_seal.py Outdated
Comment threadscripts/seal_tests/zokrates_test_seal.py Outdated
Comment threadsrc/front/c/mod.rs Outdated
Comment threadsrc/target/fhe/trans.rs
Comment threadsrc/target/fhe/trans.rs
Comment threadsrc/target/fhe/trans.rs
edwjchen
edwjchen reviewed Apr 26, 2022
View reviewed changes

@edwjchenedwjchen left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments!

@alex-ozdemir when you have a minute, could you take a look at the Map IR lowering?

Comment threadscripts/build_fhe_zokrates_test.zsh Outdated
Comment thread.vscode/settings.json
Comment threadexamples/C/fhe/unit_tests/arithmetic_tests/2pc_add.c
Comment threadscripts/seal_tests/custom_tests/batch_add_bytecode.txt Outdated
Comment threadscripts/seal_tests/util.py Outdated
Comment threadsrc/target/fhe/trans.rs Outdated
Comment threadsrc/target/fhe/utils.rs
alex-ozdemir
alex-ozdemir approved these changes Apr 27, 2022
View reviewed changes

@alex-ozdemiralex-ozdemir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a nit and two questions.

Comment threadsrc/target/fhe/trans.rs Outdated
Comment threadsrc/target/fhe/trans.rs
@edwjchen
edwjchen self-requested a review April 27, 2022 05:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-ozdemiralex-ozdemiralex-ozdemir approved these changes
@edwjchenedwjchenedwjchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Northrim@alex-ozdemir@edwjchen