Skip to content

chore: remove stale FIXME on snapshot URL defaults - #307

Merged
ZhiyuCircle merged 1 commit into
circlefin:mainfrom
kutluhaneth46:chore/remove-stale-snapshot-url-fixme
Sep 10, 2026
Merged

ZhiyuCircle merged 1 commit into
circlefin:mainfrom
kutluhaneth46:chore/remove-stale-snapshot-url-fixme

Conversation

@kutluhaneth46

Copy link
Copy Markdown
Contributor

Summary

Remove two stale FIXME: Update this to the actual snapshot URL comments on https://snapshots.arc.network/5042002 — already the production testnet snapshot URL documented in docs/running-an-arc-node.md and used by crates/snapshots.

Fixes #275.

Test plan

  • Comments-only change; no behavior change

@osr21

osr21 commented Sep 1, 2026

Copy link
Copy Markdown

Verified — this is exactly the two-line removal discussed on #275, and re-checking today confirms it still holds:

  • https://snapshots.arc.network/5042002/latest.txt200, now pointing at snapshot-arc-testnet-pruned-execution-20260901T2005Z-59988657.tar.lz4 (a newer pointer than when I checked on chore: stale FIXME comments on snapshot URL in execution-config defaults (already the real URL) #275, confirming this is a live, rolling production feed, not a stale placeholder).
  • Both DEFAULT_DOWNLOAD_URL and the available_snapshots entry it removes the FIXME from are self-contained to this file — no other crate consumes them, and crates/snapshots/src/download.rs + docs/running-an-arc-node.md independently reference the same host without any "provisional" caveat. Comments-only, no behavior change, matches the test plan.

Two non-blocking items from the #275 discussion that this PR doesn't touch — flagging in case they're wanted here or in a follow-up, not asking for a respin of this diff:

  1. Base-URL 404 trap: https://snapshots.arc.network/5042002 (bare) still 404s today — it's a prefix, not a fetchable object; only <base>/latest.txt resolves. Removing the FIXME without a word on that is the one way this exact confusion reappears (a future contributor curls the bare URL, gets a 404, adds a new FIXME). A one-line comment on DEFAULT_DOWNLOAD_URL noting the pointer path would close that loop for good.
  2. L40 label-in-URL: Cow::Borrowed("https://snapshots.arc.network/5042002 (testnet)") embeds a " (testnet)" suffix inside the string. Harmless while available_snapshots is display-only, but it stops being a valid URL the moment anything treats that vec as fetchable — worth splitting the label from the URL if this file gets touched again.

Also for completeness: I checked the devnet URL (5042001) independently this time — latest.txt still 404s ("No snapshot available"), same as when the issue was filed. That's ops/data state, not a wrong URL, and doesn't affect this PR's correctness either way.

No conflicts with other open PRs — nothing else in the tree currently touches crates/execution-config/src/defaults.rs.

@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

Thanks @osr21 for the re-verification — glad the snapshot URL check still holds.

@kutluhaneth46
kutluhaneth46 force-pushed the chore/remove-stale-snapshot-url-fixme branch from 3827c5e to 3581d4d Compare September 6, 2026 14:16
@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

@ZhiyuCircle — tiny follow-up if you have a moment: removes a stale FIXME on the live snapshot URL defaults (verified still serving 200). Two-line cleanup, mergeable against current main.

@ZhiyuCircle ZhiyuCircle added the pending-import Merged PR awaiting reverse-sync to upstream label Sep 9, 2026
@ZhiyuCircle

Copy link
Copy Markdown
Contributor

Can't merge, could you help to update signature for the commit ?

@kutluhaneth46
kutluhaneth46 force-pushed the chore/remove-stale-snapshot-url-fixme branch from 3581d4d to 1c35cc4 Compare September 9, 2026 20:47
@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

@ZhiyuCircle Rebased onto current main and re-signed the commit (SSH signature, author KutluhanETH <airdropzamani.resmi@gmail.com>). Please try merging again — happy to adjust further if GitHub still wants a different signing key on the account.

@kutluhaneth46
kutluhaneth46 force-pushed the chore/remove-stale-snapshot-url-fixme branch from 1c35cc4 to 8bb7b9a Compare September 9, 2026 20:48
@kutluhaneth46
kutluhaneth46 force-pushed the chore/remove-stale-snapshot-url-fixme branch from 8bb7b9a to cfb41e9 Compare September 9, 2026 21:09
@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

@ZhiyuCircle Commit is now Verified (SSH signing key on my account). Should be ready to merge — thanks again.

@ZhiyuCircle
ZhiyuCircle merged commit de76122 into circlefin:main Sep 10, 2026
18 checks passed
@circle-github-action-bot circle-github-action-bot added imported and removed pending-import Merged PR awaiting reverse-sync to upstream labels Sep 10, 2026
@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

Thanks for the review and merge, @ZhiyuCircle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: stale FIXME comments on snapshot URL in execution-config defaults (already the real URL)

4 participants