fix(genesis): align ProtocolConfig schema with runtime consensus/fee checks - #359
Merged
ZhiyuCircle merged 1 commit intoSep 8, 2026
Conversation
…checks Reject zero consensus timeouts and values above uint16 (packed storage), and require minBaseFee <= maxBaseFee so genesis cannot accept configs that updateConsensusParams / updateFeeParams would reject.
ZhiyuCircle
approved these changes
Sep 8, 2026
Contributor
Author
|
Thanks for the review and merge, @ZhiyuCircle — appreciated the quick pass on the genesis/runtime invariant alignment. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the genesis/runtime invariant gaps discussed on #321 (and related to #320):
> 0and<= uint16— they are packed as 8×uint16into one storage slot, andupdateConsensusParamsrejects zero timeouts. Unbounded genesis values could overflow neighboring packed lanes or boot a chain with a zero propose timeout.minBaseFee <= maxBaseFee— matchesupdateFeeParams/InvalidBaseFeeRange.blockGasLimit > 0is already covered by #321 / open PRs, so this change leaves that field alone.Test plan
tests/unit/protocol-config-genesis.test.tscovering zero timeouts,65536overflow, and inverted base-fee rangemake test-unit(or the repo's hardhat unit target) once CI/maintainers can run itRelated: #320, #321