add docker

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.

[MarketMadi]

created barebones dockerfile to get node running. changed logging to fail gracefully is terminal is not available (like in a docker container) but logs still saved to debug file and display in docker.

it can easily be run and built.

docker build -t civkit-node .
docker run --rm civkit-node

[ffaex]

Hi, could you please remove all files from this PR except for Dockerfile, README.md, src/util.rs as those are not relevant for adding docker. I want to avoid merge conflicts. Best is probably by merging my PR and then rebasing.

Dockerfile looks great. Might expose ports for Websockets, so civkit-cli and civkit-sample can connect.

[ffaex]

might replace "cargo build" with "cargo build --release --bin=civkitd"

[MarketMadi]

Made those changes. Rebased, and exposed ports. ports can also be exposed with -p but good to include in dockerfile. Feel free to review.

[ffaex]

looks good, should build if you do those 2 little changes

[ffaex]

path should be to release binary I think.

[MarketMadi]

i agree. if future users want to use debug in docker, they can change those lines pretty easily

[ffaex]

we are compiling only the "civkitd" binary as well, so we should only copy that

[MarketMadi]

i left them thinking they could be useful for debugging / development purposes. i think we should do what you propose, keep it lean.