Skip to content

added "fuzzy" mode to __eq__ of CLAMS vocab subclasses - #210

Merged
keighrim merged 1 commit into
developfrom
209-fuzzy-attype_eq
May 1, 2023
Merged

added "fuzzy" mode to __eq__ of CLAMS vocab subclasses#210
keighrim merged 1 commit into
developfrom
209-fuzzy-attype_eq

Conversation

@keighrim

Copy link
Copy Markdown
Member

This PR fixes#209 .

* made fuzzy mode as default
* made fuzzy matching work with `get_alignments` method
* added all-merged `typevers` dict to vocab package
* made at_type version compat test cases to check for version difference warnings
@codecov

codecovBot commented May 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #210 (c79b2e9) into develop (3e462ac) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## develop #210 +/- ##
===========================================
- Coverage 94.30% 94.29% -0.01% 
===========================================
Files 6 6 Lines 772 771 -1 ===========================================
- Hits 728 727 -1 
Misses 44 44 
FlagCoverage Δ
unittests94.29% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
mmif/serialize/mmif.py97.35% <100.00%> (-0.02%)⬇️
mmif/serialize/view.py95.94% <100.00%> (ø)

@keighrim
keighrim merged commit 72f5356 into developMay 1, 2023
@keighrim
keighrim deleted the 209-fuzzy-attype_eq branch May 1, 2023 20:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

support "fuzzy" comparison of at_type IRIs (not considering versions)

1 participant

@keighrim