Uh oh!
There was an error while loading. Please reload this page.
adding sanitized serialize - #212
Merged
Merged
Conversation
* validating output using built-in MMIF jsonschema * remove non-existing annotation types from ``contains`` metadata
Codecov Report
@@ Coverage Diff @@## develop #212 +/- ##
===========================================
+ Coverage 94.29% 94.40% +0.11%
===========================================
Files 6 6 Lines 771 787 +16 ===========================================
+ Hits 727 743 +16
Misses 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* this was a problem mainly because we do not allow an empty `annotations` list while allowing an empty `metadata.contains`. * Mmif._serialize() method ignores any "empty" attributes during serialization, resulting in view.metadata that has neither `contains`, `error`, nor `warnings` when "safe_serializing" a view with an empty `annotations` list. * this implementation inserts an empty dict back to view.metadata as a `contains`
…serialize` of Mmif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#205, reopening of #211.