Skip to content

mmif objects now can exclude some of their attributes from __eq__ comp - #216

Merged
keighrim merged 1 commit into
developfrom
214-diff-bug
May 19, 2023
Merged

mmif objects now can exclude some of their attributes from __eq__ comp#216
keighrim merged 1 commit into
developfrom
214-diff-bug

Conversation

@keighrim

Copy link
Copy Markdown
Member

closes#214

@codecov

codecovBot commented May 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #216 (216b012) into develop (03ed50e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## develop #216 +/- ##
===========================================
+ Coverage 94.57% 94.61% +0.04% 
===========================================
Files 6 6 Lines 793 799 +6 ===========================================
+ Hits 750 756 +6 
Misses 43 43 
FlagCoverage Δ
unittests94.61% <100.00%> (+0.04%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
mmif/serialize/annotation.py94.41% <100.00%> (+0.02%)⬆️
mmif/serialize/model.py90.41% <100.00%> (+0.13%)⬆️
mmif/serialize/view.py96.17% <100.00%> (+0.04%)⬆️

@keighrim
keighrim merged commit ae8ea3e into developMay 19, 2023
@keighrim
keighrim deleted the 214-diff-bug branch May 19, 2023 08:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

View.__eq__ return false with identical objects

1 participant

@keighrim