Uh oh!
There was an error while loading. Please reload this page.
Replaced DocumentTypes type hint with DocumentTypesBase - #353
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes type hint issues in the mmif.Mmif class methods that were causing both pytype errors and runtime crashes when using DocumentTypes in type annotations.
Changes:
- Updated type hints to use
DocumentTypesBaseinstead ofDocumentTypesorAny - Added
DocumentTypesBaseto imports inmmif/serialize/mmif.py
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## develop #353 +/- ##
========================================
Coverage 65.56% 65.56% ========================================
Files 22 22 Lines 2843 2843 ========================================
Hits 1864 1864 Misses 979 979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
acf9a29 to
73da13eCompareUh oh!
There was an error while loading. Please reload this page.
fixes#351