Phone terminal: tap opens links, keyboard no longer toggles on tap - #228
Merged
pallaoro merged 2 commits intoSep 5, 2026
Merged
Conversation
SwiftTerm tied keyboard visibility to first-responder status, so every tap on the output flipped the keyboard, link taps were gated behind a hover check that touch can never satisfy, and the bridge dropped the open-link callback. The terminal now stays first responder and shows or hides the keyboard by swapping its input view; a tap opens a link, clears a selection, or asks for the keyboard near the cursor, and never hides it. Tapped http(s) URLs reach JS and open with Linking. Verified live: the wrapped Claude Code /login URL opened whole and the login completed.
…aseo-paseo-how-do-they-manage-the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
/loginURL opened Safari with the full URL and the login completed on the box.