Uh oh!
There was an error while loading. Please reload this page.
fix(init): tighten bootstrap flow (skip redundant confirm, put next steps last) - #184
Conversation
🦋 Changeset detectedLatest commit: 6bb53b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 7 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request modifies the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railly
left a comment
There was a problem hiding this comment.
Nit: Tests assert call counts but not order, if someone moves printBootstrapNextSteps above installSkills again, nothing catches it. Capture captured.out and assert next-steps appears after the skills call. (index.test.ts:172-214)
Overall, LGTM
In bootstrap flows (`--starter` or an empty directory), the user has already consented to project creation, so the secondary "Proceed?" scaffold prompt is redundant. The scaffold preview is still printed.
Move the bootstrap next-steps block (`cd <project>`, `<pm> dev`, etc.) to run after the "Install agent skills?" prompt so those steps remain the last thing visible when the command finishes, instead of getting buried above the skills prompt.
Addresses review nit: previous tests only verified call counts, not order. A call-order sentinel array now catches any future regression where next-steps printing is moved before skills installation.
ff1a815 to
6bb53b3CompareUh oh!
There was an error while loading. Please reload this page.
Summary
Two small bootstrap-flow polish fixes for
clerk init:--starteror implicit bootstrap on an empty directory), the user already opted into project creation, so the secondary? Proceed?scaffold prompt is dropped. The scaffold preview (CREATE/MODIFYlist) is still printed.→ cd <project>,→ <pm> dev,→ clerk auth login) to run after the "Install agent skills?" prompt, so those steps stay on-screen as the final thing the user sees when the command finishes.Existing-project flows are unchanged.
Test plan
bun run format/lint/typecheck/testpass--starterwithout-yskips scaffold "Proceed?"clerk init --starterin a fresh tmpdir — confirm no "Proceed?" after preview; confirm→ cd … / → <pm> devappears as the final block before└ Doneclerk initin an empty dir → same verification as aboveclerk initin an existing linked project → "Proceed?" still appears; no bootstrap next steps printed (unchanged behavior)