fix(test/e2e): make users-list importable by refresh-fixtures script by wyattjoh · Pull Request #255 · clerk/cli

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wyattjoh · 2026-05-01T20:57:27Z

Summary

The biweekly Refresh E2E Fixtures workflow has been failing on main since #237 landed test/e2e/users-list.test.ts. The refresh script imports every test/e2e/*.test.ts file to read each one's FixtureConfig, but users-list.test.ts threw at module top-level when CLERK_CLI_TEST_APP_ID and CLERK_PLATFORM_API_KEY were unset, which they are in that workflow because the script does not actually need them.

This change moves the env-var requirement into beforeAll, wraps the bun:test hook registrations in a CLERK_REFRESH_FIXTURES guard (matching the convention in test/e2e/lib/fixture-test.ts), and teaches the refresh script to skip imported files that do not export a FixtureConfig. Either fix on its own is insufficient: bun:test's beforeAll itself throws when called outside the runner, and even with the file made import-safe, the script still crashes on config.pinned for non-fixture files. The combination also future-proofs the refresh against the next non-fixture e2e test that lands.

Test plan

bun run format / lint / typecheck / test clean locally
CLERK_REFRESH_FIXTURES=1 bun -e "import('./test/e2e/users-list.test.ts')" succeeds
bun run e2e:refresh-fixtures -- --only nextjs-pages-router runs end-to-end
Manually trigger the Refresh E2E Fixtures workflow on main after merge to verify

The refresh-fixtures workflow imports every test/e2e/*.test.ts file to read its FixtureConfig export. users-list.test.ts threw at module load when CLERK_CLI_TEST_APP_ID / CLERK_PLATFORM_API_KEY were unset, breaking the scheduled refresh on main. Move the env-var requirement into beforeAll and guard the bun:test registrations behind CLERK_REFRESH_FIXTURES, matching the convention in test/e2e/lib/fixture-test.ts. Also teach the refresh script to skip imported files that don't export a config so future non-fixture e2e tests don't reintroduce this failure mode.

wyattjoh · 2026-05-01T20:57:30Z

Stack: wyattjoh/fix-refresh-fixtures-import

fix(test/e2e): make users-list importable by refresh-fixtures script #255 👈 this PR

Part of a stacked PR chain. Do not merge manually.

changeset-bot · 2026-05-01T20:57:31Z

⚠️ No Changeset found

Latest commit: 1a9eb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-01T20:59:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 568637ee-d333-405d-b6bb-3477ded336b7

📥 Commits

Reviewing files that changed from the base of the PR and between 6d95835 and 1a9eb41.

📒 Files selected for processing (2)

scripts/refresh-e2e-fixtures.ts
test/e2e/users-list.test.ts

📝 Walkthrough

Walkthrough

The pull request refactors e2e test fixture handling. The refresh script now treats FixtureConfig as an optional export from e2e test modules, checking for its presence after import and failing fast when running with --only if config is absent, or skipping the module otherwise. The users-list test file moves environment variable validation and test execution logic into a guard that only runs when not refreshing fixtures, wrapping the setup (user creation), test execution (CLI command), and teardown (user deletion) into a conditional block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: making the users-list test importable by the refresh-fixtures script, which is the core problem this PR addresses.
Description check	✅ Passed	The description provides clear context about the workflow failure caused by users-list.test.ts, explains the root cause, details the solution approach, and includes a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Railly approved these changes May 1, 2026
View reviewed changes

wyattjoh merged commit 2eeb31d into mainMay 1, 2026
11 checks passed