Uh oh!
There was an error while loading. Please reload this page.
feat(init): install the clerk-expo setup skill for Expo projects - #328
Conversation
The expo entry in FRAMEWORK_SKILL_MAP (added in #86, 2026-04) predates the mobile/clerk-expo setup skill (added to clerk/skills in 2026-05), so Expo inits only got clerk-expo-patterns. The map now supports multiple skills per framework and Expo installs both. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 438581c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR refactors the skills system to support multiple framework-specific skills per framework. FRAMEWORK_SKILL_MAP now maps frameworks to arrays of skills; getFrameworkSkills() returns all mapped skills; resolveUpstreamSkills(), formatSkillsSummary(), and formatSkillsPromptMessage() operate on skill arrays; installSkills() and runSkillsAdd() use the array-based summaries. Tests cover Expo mapping to both "clerk-expo" and "clerk-expo-patterns", and release notes document the change. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli-core/src/commands/init/skills.ts`:
- Around line 70-72: getFrameworkSkills currently returns the original array
from FRAMEWORK_SKILL_MAP which allows external mutation; change
getFrameworkSkills to return an immutable copy of the skills array (e.g., create
a new array via slice/spread or Object.freeze) when
FRAMEWORK_SKILL_MAP[frameworkDep] exists, while still returning an empty array
for unknown frameworkDep, so callers cannot modify the global
FRAMEWORK_SKILL_MAP contents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d7d6df06-9251-4bce-91ff-470e6da2f40b
📒 Files selected for processing (3)
.changeset/init-expo-setup-skill.mdpackages/cli-core/src/commands/init/skills.test.tspackages/cli-core/src/commands/init/skills.ts
| export function getFrameworkSkills(frameworkDep: string | undefined): string[] { | ||
| return (frameworkDep && FRAMEWORK_SKILL_MAP[frameworkDep]) || []; | ||
| } |
There was a problem hiding this comment.
Return an immutable/copy value from getFrameworkSkills to prevent global map mutation.
Line 71 currently leaks the original array stored in FRAMEWORK_SKILL_MAP. Because this function is exported, any caller can mutate that array and silently change future skill resolution/install behavior.
Suggested fix
-export function getFrameworkSkills(frameworkDep: string | undefined): string[] {- return (frameworkDep && FRAMEWORK_SKILL_MAP[frameworkDep]) || [];+export function getFrameworkSkills(frameworkDep: string | undefined): readonly string[] {+ const skills = frameworkDep ? FRAMEWORK_SKILL_MAP[frameworkDep] : undefined;+ return skills ? [...skills] : [];
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/cli-core/src/commands/init/skills.ts` around lines 70 - 72,
getFrameworkSkills currently returns the original array from FRAMEWORK_SKILL_MAP
which allows external mutation; change getFrameworkSkills to return an immutable
copy of the skills array (e.g., create a new array via slice/spread or
Object.freeze) when FRAMEWORK_SKILL_MAP[frameworkDep] exists, while still
returning an empty array for unknown frameworkDep, so callers cannot modify the
global FRAMEWORK_SKILL_MAP contents.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
Could if you like just modify the return type to be readonly which would enforce it on the type layer like:
| exportfunctiongetFrameworkSkills(frameworkDep: string|undefined): string[]{ | |
| return(frameworkDep&&FRAMEWORK_SKILL_MAP[frameworkDep])||[]; | |
| } | |
| exportfunctiongetFrameworkSkills(frameworkDep: string|undefined): ReadonlyArray<string>{ | |
| return(frameworkDep&&FRAMEWORK_SKILL_MAP[frameworkDep])||[]; | |
| } |
There was a problem hiding this comment.
Applied in 438581c, one level up from the return-type fix: FRAMEWORK_SKILL_MAP itself is now Record<string, readonly string[]>, so immutability is declared at the source and getFrameworkSkills inherits readonly string[] (matching the existing annotations on the format helpers).
Skipped the runtime copy — both callers only iterate, and with the readonly type any future mutation fails typecheck at the call site.
Review feedback on the FRAMEWORK_SKILL_MAP leak: type the map as Record<string, readonly string[]> so immutability is declared at the source and getFrameworkSkills inherits it, instead of copying at runtime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
clerk initon Expo projects only installsclerk-expo-patterns. Theexpoentry inFRAMEWORK_SKILL_MAP(#86, April) predates themobile/clerk-exposetup skill (clerk/skills@7f7b6ea, May), so the dedicated Expo setup skill never made it into the init flow.This makes the framework skill map support multiple skills per framework and adds
clerk-expofor Expo inits. Prompt summary becomes(clerk-cli + core + features + expo + expo-patterns).If the exclusion was deliberate, feel free to close — we'll note the intent in docs instead. Surfaced while tightening CLI ↔ Skills cross-referencing in clerk-docs#3427 (DOCS-11816).