Skip to content

fix(agent): don't hint at a sandbox for ordinary network failures - #342

Merged
rafa-thayto merged 2 commits into
mainfrom
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged

fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom
fix/sandbox-hint-network-failures

Conversation

@rafa-thayto

@rafa-thaytorafa-thayto commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

In agent mode (stdout not a TTY), any network failure printed a two-line hint:

Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.

Test plan

  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes

Fixes#331

@coderabbitai

coderabbitaiBot commented Jun 16, 2026•
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78

📥 Commits

Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.

📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot

changeset-botBot commented Jun 16, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3a16281

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
clerkPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wyattjoh
wyattjoh reviewed Jun 17, 2026
View reviewed changes

@wyattjohwyattjoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.

Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed the fix/sandbox-hint-network-failures branch from b54ab71 to 3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto merged commit 5ab2317 into mainJun 22, 2026
10 checks passed
@rafa-thayto
rafa-thayto deleted the fix/sandbox-hint-network-failures branch June 22, 2026 19:31
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell

2 participants

@rafa-thayto@wyattjoh
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(agent): don't hint at a sandbox for ordinary network failures by rafa-thayto · Pull Request #342 · clerk/cli · GitHub
Skip to content
fix(agent): don't hint at a sandbox for ordinary network failures - #342
Merged
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged
fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Conversation
@rafa-thayto
@rafa-thaytorafa-thayto
commented
Jun 16, 2026

Copy link


Copy Markdown

Contributor
Summary
In agent mode (stdout not a TTY), any network failure printed a two-line hint:
Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.
Test plan
  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes
Fixes#331
@coderabbitai
coderabbitaiBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.
Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.
🚦 How do rate limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.
Please see our Fair Usage Limits Policy for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78
📥 Commits
Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.
📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3a16281
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
clerkPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
wyattjoh
wyattjoh
reviewed
Jun 17, 2026
View reviewed changes
@wyattjohwyattjoh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.
Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed
the
fix/sandbox-hint-network-failures
branch
from
b54ab71 to
3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto
merged commit 5ab2317
into
mainJun 22, 2026

10 checks passed

@rafa-thayto
rafa-thayto
deleted the

fix/sandbox-hint-network-failures

branch
June 22, 2026 19:31
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell


2 participants

@rafa-thayto@wyattjoh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(agent): don't hint at a sandbox for ordinary network failures by rafa-thayto · Pull Request #342 · clerk/cli · GitHub
Skip to content
fix(agent): don't hint at a sandbox for ordinary network failures - #342
Merged
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged
fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Conversation
@rafa-thayto
@rafa-thaytorafa-thayto
commented
Jun 16, 2026

Copy link


Copy Markdown

Contributor
Summary
In agent mode (stdout not a TTY), any network failure printed a two-line hint:
Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.
Test plan
  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes
Fixes#331
@coderabbitai
coderabbitaiBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.
Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.
🚦 How do rate limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.
Please see our Fair Usage Limits Policy for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78
📥 Commits
Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.
📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3a16281
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
clerkPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
wyattjoh
wyattjoh
reviewed
Jun 17, 2026
View reviewed changes
@wyattjohwyattjoh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.
Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed
the
fix/sandbox-hint-network-failures
branch
from
b54ab71 to
3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto
merged commit 5ab2317
into
mainJun 22, 2026

10 checks passed

@rafa-thayto
rafa-thayto
deleted the

fix/sandbox-hint-network-failures

branch
June 22, 2026 19:31
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell


2 participants

@rafa-thayto@wyattjoh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(agent): don't hint at a sandbox for ordinary network failures by rafa-thayto · Pull Request #342 · clerk/cli · GitHub
Skip to content
fix(agent): don't hint at a sandbox for ordinary network failures - #342
Merged
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged
fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Conversation
@rafa-thayto
@rafa-thaytorafa-thayto
commented
Jun 16, 2026

Copy link


Copy Markdown

Contributor
Summary
In agent mode (stdout not a TTY), any network failure printed a two-line hint:
Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.
Test plan
  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes
Fixes#331
@coderabbitai
coderabbitaiBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.
Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.
🚦 How do rate limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.
Please see our Fair Usage Limits Policy for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78
📥 Commits
Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.
📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3a16281
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
clerkPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
wyattjoh
wyattjoh
reviewed
Jun 17, 2026
View reviewed changes
@wyattjohwyattjoh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.
Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed
the
fix/sandbox-hint-network-failures
branch
from
b54ab71 to
3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto
merged commit 5ab2317
into
mainJun 22, 2026

10 checks passed

@rafa-thayto
rafa-thayto
deleted the

fix/sandbox-hint-network-failures

branch
June 22, 2026 19:31
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell


2 participants

@rafa-thayto@wyattjoh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(agent): don't hint at a sandbox for ordinary network failures by rafa-thayto · Pull Request #342 · clerk/cli · GitHub
Skip to content
fix(agent): don't hint at a sandbox for ordinary network failures - #342
Merged
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged
fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Conversation
@rafa-thayto
@rafa-thaytorafa-thayto
commented
Jun 16, 2026

Copy link


Copy Markdown

Contributor
Summary
In agent mode (stdout not a TTY), any network failure printed a two-line hint:
Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.
Test plan
  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes
Fixes#331
@coderabbitai
coderabbitaiBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.
Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.
🚦 How do rate limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.
Please see our Fair Usage Limits Policy for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78
📥 Commits
Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.
📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3a16281
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
clerkPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
wyattjoh
wyattjoh
reviewed
Jun 17, 2026
View reviewed changes
@wyattjohwyattjoh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.
Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed
the
fix/sandbox-hint-network-failures
branch
from
b54ab71 to
3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto
merged commit 5ab2317
into
mainJun 22, 2026

10 checks passed

@rafa-thayto
rafa-thayto
deleted the

fix/sandbox-hint-network-failures

branch
June 22, 2026 19:31
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell


2 participants

@rafa-thayto@wyattjoh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(agent): don't hint at a sandbox for ordinary network failures by rafa-thayto · Pull Request #342 · clerk/cli · GitHub
Skip to content
fix(agent): don't hint at a sandbox for ordinary network failures - #342
Merged
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged
fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Conversation
@rafa-thayto
@rafa-thaytorafa-thayto
commented
Jun 16, 2026

Copy link


Copy Markdown

Contributor
Summary
In agent mode (stdout not a TTY), any network failure printed a two-line hint:
Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.
Test plan
  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes
Fixes#331
@coderabbitai
coderabbitaiBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.
Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.
🚦 How do rate limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.
Please see our Fair Usage Limits Policy for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78
📥 Commits
Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.
📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3a16281
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
clerkPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
wyattjoh
wyattjoh
reviewed
Jun 17, 2026
View reviewed changes
@wyattjohwyattjoh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.
Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed
the
fix/sandbox-hint-network-failures
branch
from
b54ab71 to
3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto
merged commit 5ab2317
into
mainJun 22, 2026

10 checks passed

@rafa-thayto
rafa-thayto
deleted the

fix/sandbox-hint-network-failures

branch
June 22, 2026 19:31
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell


2 participants

@rafa-thayto@wyattjoh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(agent): don't hint at a sandbox for ordinary network failures by rafa-thayto · Pull Request #342 · clerk/cli · GitHub
Skip to content
fix(agent): don't hint at a sandbox for ordinary network failures - #342
Merged
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged
fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Conversation
@rafa-thayto
@rafa-thaytorafa-thayto
commented
Jun 16, 2026

Copy link


Copy Markdown

Contributor
Summary
In agent mode (stdout not a TTY), any network failure printed a two-line hint:
Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.
Test plan
  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes
Fixes#331
@coderabbitai
coderabbitaiBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.
Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.
🚦 How do rate limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.
Please see our Fair Usage Limits Policy for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78
📥 Commits
Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.
📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3a16281
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
clerkPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
wyattjoh
wyattjoh
reviewed
Jun 17, 2026
View reviewed changes
@wyattjohwyattjoh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.
Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed
the
fix/sandbox-hint-network-failures
branch
from
b54ab71 to
3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto
merged commit 5ab2317
into
mainJun 22, 2026

10 checks passed

@rafa-thayto
rafa-thayto
deleted the

fix/sandbox-hint-network-failures

branch
June 22, 2026 19:31
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell


2 participants

@rafa-thayto@wyattjoh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(agent): don't hint at a sandbox for ordinary network failures by rafa-thayto · Pull Request #342 · clerk/cli · GitHub
Skip to content
fix(agent): don't hint at a sandbox for ordinary network failures - #342
Merged
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Jun 22, 2026
Merged
fix(agent): don't hint at a sandbox for ordinary network failures#342
rafa-thayto merged 2 commits into
mainfrom 
fix/sandbox-hint-network-failures
Conversation
@rafa-thayto
@rafa-thaytorafa-thayto
commented
Jun 16, 2026

Copy link


Copy Markdown

Contributor
Summary
In agent mode (stdout not a TTY), any network failure printed a two-line hint:
Host-only Clerk state … This may be a sandboxed run.
Re-run this command on the host shell before trusting auth, link, env, or API failures.

isLikelySandboxFailure returned true for all network errors with no inspection, so it fired identically on a plain host shell where a host was simply unreachable (e.g. VPN-gated), sending users down the wrong path. Network failures now require a permission-like error (EPERM/EACCES/sandbox/…) before hinting — real seatbelt/seccomp blocks still warn; ECONNREFUSED/ENOTFOUND/ETIMEDOUT do not. The hint is also collapsed to a single line. browser-launch and localhost-bind keep their existing behavior.
Test plan
  • New src/lib/host-execution.test.ts covers: plain connectivity failure → no hint; permission-like failure → hint; browser-launch → hint; single line; human mode → no hint
  • doctor.test.ts still passes
Fixes#331
@coderabbitai
coderabbitaiBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@rafa-thayto, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 56 minutes and 8 seconds. Learn how PR review limits work.
Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.
🚦 How do rate limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.
Please see our Fair Usage Limits Policy for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66997e6b-b7ae-478c-b713-369bd24bca78
📥 Commits
Reviewing files that changed from the base of the PR and between 4240dd5 and 3a16281.
📒 Files selected for processing (3)
  • .changeset/sandbox-hint-network-failures.md
  • packages/cli-core/src/lib/host-execution.test.ts
  • packages/cli-core/src/lib/host-execution.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3a16281
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
clerkPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
wyattjoh
wyattjoh
reviewed
Jun 17, 2026
View reviewed changes
@wyattjohwyattjoh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped fix: network failures now require a permission-like error before hinting at a sandbox, while browser-launch and localhost-bind keep warning on any failure. CI checks (lint, format, typecheck, tests) and the changeset all pass.
Comment threadpackages/cli-core/src/lib/host-execution.ts
@rafa-thayto
fix(agent): only hint at a sandbox for permission-like network failures
df8b3a2
The agent-mode sandbox hint fired on every network failure, including plain
unreachable hosts (VPN, DNS, ECONNREFUSED) on a normal host shell, where it was
misleading. Require a permission-like error before hinting, and collapse the
two-line message to one.
Fixes#331
@rafa-thayto
fix(agent): check error.code and error.cause for permission-like netw…
3a16281
…ork failures
Bun's fetch collapses connectivity failures into a generic message and puts
the discriminator on error.code (e.g. ConnectionRefused) and error.cause.
Extend isPermissionLikeFailure to also inspect error.code and recursively
check error.cause so sandbox detection works for real Bun fetch error shapes.
Add test cases covering Bun-style errors with .code and .cause.
@rafa-thayto
rafa-thaytoforce-pushed
the
fix/sandbox-hint-network-failures
branch
from
b54ab71 to
3a16281CompareJune 18, 2026 12:18
@rafa-thayto
rafa-thayto
merged commit 5ab2317
into
mainJun 22, 2026

10 checks passed

@rafa-thayto
rafa-thayto
deleted the

fix/sandbox-hint-network-failures

branch
June 22, 2026 19:31
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wyattjohwyattjohwyattjoh approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Network-failure hint suggests a sandboxed run even on a plain host shell


2 participants

@rafa-thayto@wyattjoh