Uh oh!
There was an error while loading. Please reload this page.
refactor(api): move bapiRequest into lib/bapi.ts - #359
Merged
Conversation
🦋 Changeset detectedLatest commit: 3888f1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rafa-thaytoforce-pushed
the
refactor/api-bapi-to-lib
branch
from
June 22, 2026 20:42
ae4e22f to
283259eCompareNo actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (7)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughWalkthrough
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
rafa-thaytoforce-pushed
the
refactor/api-bapi-to-lib
branch
from
June 26, 2026 19:59
283259e to
0989251CompareMirror the fapiRequest relocation: the BAPI passthrough wrapper now lives in lib/bapi.ts as a sibling to lib/fapi.ts, so both API clients sit in the leaf layer instead of one being a command module. Updates all importers and the relocated bapi test; no behavior change. Claude-Session: https://claude.ai/code/session_01QnfBw9qY7u19BvUWyfQGC6
rafa-thaytoforce-pushed
the
refactor/api-bapi-to-lib
branch
from
June 27, 2026 12:13
0989251 to
3888f1eComparewyattjoh
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #345.
Follow-up to the
fapiRequestrelocation in #345. That PR moved the FAPI passthrough wrapper intolib/fapi.tsand leftbapiRequestincommands/api/bapi.ts, which broke the symmetry between the two API clients. This restores it.What changed
commands/api/bapi.ts→lib/bapi.ts(now a sibling oflib/fapi.ts)commands/api/bapi.test.ts→lib/bapi.test.tsapi/index.ts,users/{create,list,lifecycle-runner}.ts,users/interactive/pick-user.ts) and theirmock.modulepathscommands/api/bapi.tsreference in theBapiErrordoc comment and.claude/rules/errors.mdBoth wrappers now live in the leaf
lib/layer and return the sharedApiResponsetype fromlib/fetch.ts(introduced in #345), so nothing inlib/imports upward fromcommands/.No behavior change — pure relocation. Empty changeset added since it touches non-exempt
packages/**paths with no user-facing impact.Test plan
bun run formatbun run lintbun run typecheckbun run test(1691 pass)https://claude.ai/code/session_01QnfBw9qY7u19BvUWyfQGC6