Preliminary Checks
Reproduction
https://github.com/calebjacob/test-sign-in-phone-number-validation-bug-reproduction
Publishable key
pk_test_Zmx1ZW50LXByaW1hdGUtMjYuY2xlcmsuYWNjb3VudHMuZGV2JA
Description
When using the signIn()test helper, a validation error will be incorrectly thrown when using valid test numbers that match the format as outlined in the docs: https://clerk.com/docs/testing/test-emails-and-phones#phone-numbers
+1 (XXX) 555-0100 to +1 (XXX) 555-0199
I can successfully sign in with both of these test phone numbers via the UI (as expected):
However, the +1303... number will cause a validation error when using clerk.signIn():
await clerk.signIn({
page,
signInParams: {
identifier: '+13035550100',
strategy: 'phone_code',
},
});
Steps to reproduce:
- Pull down reproduction repo: https://github.com/calebjacob/test-sign-in-phone-number-validation-bug-reproduction.
NOTE: Due to clerkSetup() requiring the secret key, I committed both the publishable and secret key values in .env.local for a temporary development/test Clerk project. Please let me know if there's a better way to handle this. It's a weird case since the reproduction doesn't function without the secret.
- Install and run the test suite:
Expected behavior:
Test suite succeeds signing in user with both, valid testing phone numbers:
Actual behavior:
An error is thrown:
Error: page.evaluate: Error: Clerk: Failed to sign in: Phone number should be a test phone number.
Example: +15555550100.
Learn more here: https://clerk.com/docs/testing/test-emails-and-phones#phone-numbers
A quick glance at the source code shows why this is happening:
| if(signInParams.strategy==='phone_code'&&!signInParams.identifier.includes('+155555501')){ |
The current logic doesn't allow for differing area codes:
!signInParams.identifier.includes('+155555501')This might be a simple solution?
!/\+1\d{3}55501\d{2}/.test(signInParams.identifier)I'm happy to publish a quick PR to resolve this if that would be helpful. Thanks!
Environment
System:
OS: macOS 15.5
CPU: (16) arm64 Apple M4 Max
Memory: 1.06 GB / 64.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 22.14.0 - ~/.nvm/versions/node/v22.14.0/bin/node
npm: 10.9.2 - ~/.nvm/versions/node/v22.14.0/bin/npm
pnpm: 10.10.0 - /opt/homebrew/bin/pnpm
Browsers:
Brave Browser: 138.1.80.113
Safari: 18.5
npmPackages:
@clerk/clerk-react: ^5.2.10 => 5.2.10
@clerk/testing: ^1.9.1 => 1.9.1
@playwright/test: ^1.53.2 => 1.53.2
@types/node: ^22.0.0 => 22.0.0
@types/react: ^18.3.3 => 18.3.3
@types/react-dom: ^18.3.0 => 18.3.0
@vitejs/plugin-react: ^4.3.1 => 4.3.1
autoprefixer: ^10.4.19 => 10.4.19
dotenv: ^17.0.1 => 17.0.1
eslint: ^9.7.0 => 9.7.0
eslint-plugin-react: ^7.34.4 => 7.34.4
eslint-plugin-react-hooks: ^4.6.2 => 4.6.2
eslint-plugin-react-refresh: ^0.4.8 => 0.4.8
postcss: ^8.4.40 => 8.4.40
prettier: 3.3.3 => 3.3.3
react: ^18.3.1 => 18.3.1
react-dom: ^18.3.1 => 18.3.1
react-router-dom: ^6.25.1 => 6.25.1
tailwind: ^4.0.0 => 4.0.0
tailwindcss: ^3.4.7 => 3.4.7
ts-node: ^10.9.2 => 10.9.2
typescript: ^5.5.4 => 5.5.4
vite: ^5.3.5 => 5.3.5
Preliminary Checks
I have reviewed the documentation: https://clerk.com/docs
I have searched for existing issues: https://github.com/clerk/javascript/issues
I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)
This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.
Reproduction
https://github.com/calebjacob/test-sign-in-phone-number-validation-bug-reproduction
Publishable key
pk_test_Zmx1ZW50LXByaW1hdGUtMjYuY2xlcmsuYWNjb3VudHMuZGV2JA
Description
When using the
signIn()test helper, a validation error will be incorrectly thrown when using valid test numbers that match the format as outlined in the docs: https://clerk.com/docs/testing/test-emails-and-phones#phone-numbersI can successfully sign in with both of these test phone numbers via the UI (as expected):
However, the
+1303...number will cause a validation error when usingclerk.signIn():Steps to reproduce:
NOTE: Due to
clerkSetup()requiring the secret key, I committed both the publishable and secret key values in.env.localfor a temporary development/test Clerk project. Please let me know if there's a better way to handle this. It's a weird case since the reproduction doesn't function without the secret.Expected behavior:
Test suite succeeds signing in user with both, valid testing phone numbers:
Actual behavior:
An error is thrown:
A quick glance at the source code shows why this is happening:
javascript/packages/testing/src/common/helpers-utils.ts
Line 20 in da2c741
The current logic doesn't allow for differing area codes:
This might be a simple solution?
I'm happy to publish a quick PR to resolve this if that would be helpful. Thanks!
Environment