Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rotten-rules-argue.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

A OrganizationMembershipRequest can now be rejected

- New `OrganizationMembershipRequest.reject` method alongside `accept`
- As an organization admin, navigate to `Organization Profile` > `Members` > `Requests`. You can now reject a request from the table.
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,12 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
});
};

reject = async (): Promise<OrganizationMembershipRequestResource> => {
return await this._basePost({
path: `/organizations/${this.organizationId}/membership_requests/${this.id}/reject`,
});
};

protected fromJSON(data: OrganizationMembershipRequestJSON | null): this {
if (data) {
this.id = data.id;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ OrganizationMembershipRequest {
"profileImageUrl": "test_url",
"userId": undefined,
},
"reject": [Function],
"status": "pending",
"updatedAt": 1970-01-01T00:00:05.678Z,
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,6 @@ const InvitationRow = (props: { invitation: OrganizationInvitationResource; onRe
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: invitation.emailAddress } } as any}
/>
</Td>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { OrganizationMembershipRequestResource } from '@clerk/types';

import { useCoreOrganization } from '../../contexts';
import { Button, Flex, localizationKeys, Td } from '../../customizables';
import { useCardState, UserPreview } from '../../elements';
import { useCardState, UserPreview, withCardStateProvider } from '../../elements';
import { handleError } from '../../utils';
import { DataTable, RowContainer } from './MemberListTable';

Expand All@@ -15,82 +15,101 @@ export const RequestToJoinList = () => {
},
});

const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

if (!organization) {
return null;
}

const approve = (request: OrganizationMembershipRequestResource) => () => {
return card
.runAsync(request.accept)
.then(mutateSwrState)
.catch(err => handleError(err, [], card.setError));
};

return (
<DataTable
page={membershipRequests?.page || 1}
onPageChange={membershipRequests?.fetchPage ?? (() => null)}
itemCount={membershipRequests?.count ?? 0}
itemsPerPage={ITEMS_PER_PAGE}
isLoading={membershipRequests?.isFetching}
isLoading={membershipRequests?.isLoading}
emptyStateLocalizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.table__emptyRow')}
headers={[
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__user'),
localizationKeys('organizationProfile.membersPage.requestsTab.tableHeader__requested'),
localizationKeys('organizationProfile.membersPage.activeMembersTab.tableHeader__actions'),
]}
rows={(membershipRequests?.data || []).map(i => (
rows={(membershipRequests?.data || []).map(request => (
<RequestRow
key={i.id}
request={i}
onAccept={approve(i)}
key={request.id}
request={request}
onError={card.setError}
/>
))}
/>
);
};

const RequestRow = (props: { request: OrganizationMembershipRequestResource; onAccept: () => unknown }) => {
const { request, onAccept } = props;
const RequestRow = withCardStateProvider(
(props: { request: OrganizationMembershipRequestResource; onError: ReturnType<typeof useCardState>['setError'] }) => {
const { request, onError } = props;
const card = useCardState();
const { membershipRequests } = useCoreOrganization();

return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>
const mutateSwrState = () => {
const unstable__mutate = (membershipRequests as any).unstable__mutate;
if (unstable__mutate && typeof unstable__mutate === 'function') {
unstable__mutate();
}
};

<Td>
<Flex>
<AcceptRejectRequestButtons onAccept={onAccept} />
</Flex>
</Td>
</RowContainer>
);
};
const onAccept = () => {
return card
.runAsync(request.accept, 'accept')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const onReject = () => {
return card
.runAsync(request.reject, 'reject')
.then(mutateSwrState)
.catch(err => handleError(err, [], onError));
};

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown }) => {
return (
<RowContainer>
<Td>
<UserPreview
sx={{ maxWidth: '30ch' }}
showAvatar={false}
user={{ primaryEmailAddress: { emailAddress: request.publicUserData.identifier } } as any}
/>
</Td>
<Td>{request.createdAt.toLocaleDateString()}</Td>

<Td>
<AcceptRejectRequestButtons {...{ onAccept, onReject }} />
</Td>
</RowContainer>
);
},
);

const AcceptRejectRequestButtons = (props: { onAccept: () => unknown; onReject: () => unknown }) => {
const card = useCardState();
return (
<>
<Flex gap={2}>
<Button
textVariant='buttonExtraSmallBold'
variant='ghost'
isLoading={card.isLoading && card.loadingMetadata === 'reject'}
isDisabled={card.isLoading && card.loadingMetadata !== 'reject'}
onClick={props.onReject}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__reject')}
/>

<Button
textVariant='buttonExtraSmallBold'
variant='solid'
isLoading={card.isLoading}
isLoading={card.isLoading && card.loadingMetadata === 'accept'}
isDisabled={card.isLoading && card.loadingMetadata !== 'accept'}
onClick={props.onAccept}
localizationKey={localizationKeys('organizationProfile.membersPage.requestsTab.menuAction__approve')}
/>
</>
</Flex>
);
};
67 changes: 35 additions & 32 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,39 +77,42 @@ export const UserPreview = (props: UserPreviewProps) => {
sx={[{ minWidth: '0px', width: '100%' }, sx]}
{...rest}
>
{showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
{imageUrl ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What is this change about?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, because

  1. We don't want to display the elements if imageUrl does not exist as the html element will reserve space
  2. We cannot use showAvatar because it will still an element that just reserves height (necessary for switcher)

Added a comment in the code, as to why this is needed

showAvatar ? (
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={{ position: 'relative' }}
>
<UserAvatar
boxElementDescriptor={descriptors.userPreviewAvatarBox}
imageElementDescriptor={descriptors.userPreviewAvatarImage}
{...user}
{...externalAccount}
{...samlAccount}
name={name}
avatarUrl={imageUrl}
size={getAvatarSizes}
sx={avatarSx}
rounded={rounded}
/>

{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)}
{icon && <Flex sx={{ position: 'absolute', left: 0, bottom: 0 }}>{icon}</Flex>}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null}

<Flex
elementDescriptor={descriptors.userPreviewTextContainer}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@ const useCardState = () => {
const setIdle = (metadata?: Metadata) => setState(s => ({ ...s, status: 'idle', metadata }));
const setError = (metadata: ClerkAPIError | Metadata) => setState(s => ({ ...s, error: translateError(metadata) }));
const setLoading = (metadata?: Metadata) => setState(s => ({ ...s, status: 'loading', metadata }));
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>)) => {
setLoading();
const runAsync = async <T = unknown,>(cb: Promise<T> | (() => Promise<T>), metadata?: Metadata) => {
setLoading(metadata);
return (typeof cb === 'function' ? cb() : cb)
.then(res => {
return res;
})
.finally(() => setIdle());
.finally(() => setIdle(metadata));
};

return {
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,6 +657,7 @@ export const enUS: LocalizationResource = {
requestsTab: {
tableHeader__requested: 'Requested access',
menuAction__approve: 'Approve',
menuAction__reject: 'Reject',
table__emptyRow: 'No requests to display',
requests: {
headerTitle: 'Requests',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -678,6 +678,7 @@ type _LocalizationResource = {
requestsTab: {
tableHeader__requested: LocalizationValue;
menuAction__approve: LocalizationValue;
menuAction__reject: LocalizationValue;
table__emptyRow: LocalizationValue;
requests: {
headerTitle: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/organizationMembershipRequest.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,5 @@ export interface OrganizationMembershipRequestResource extends ClerkResource {
updatedAt: Date;

accept: () => Promise<OrganizationMembershipRequestResource>;
reject: () => Promise<OrganizationMembershipRequestResource>;
}