6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
6 changes: 6 additions & 0 deletions .changeset/healthy-carrots-turn.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display a notification counter for organization invitations in OrganizationSwitcher
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
import { withOrganizationsEnabledGuard } from '../../common';
import { useCoreOrganizationList, withCoreUserGuard } from '../../contexts';
import { withCoreUserGuard } from '../../contexts';
import { Flow } from '../../customizables';
import { Popover, withCardStateProvider, withFloatingTree } from '../../elements';
import { usePopover } from '../../hooks';
import { OrganizationSwitcherPopover } from './OrganizationSwitcherPopover';
import { OrganizationSwitcherTrigger } from './OrganizationSwitcherTrigger';
import { organizationListParams } from './utils';

const _OrganizationSwitcher = withFloatingTree(() => {
const { floating, reference, styles, toggle, isOpen, nodeId, context } = usePopover({
placement: 'bottom-start',
offset: 8,
});

/**
* Prefetch user invitations and suggestions
*/
useCoreOrganizationList(organizationListParams);

return (
<Flow.Root flow='organizationSwitcher'>
<OrganizationSwitcherTrigger
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
import { forwardRef } from 'react';

import { useCoreOrganization, useCoreUser, useOrganizationSwitcherContext } from '../../contexts';
import { Button, descriptors, Icon, localizationKeys } from '../../customizables';
import {
useCoreOrganization,
useCoreOrganizationList,
useCoreUser,
useOrganizationSwitcherContext,
} from '../../contexts';
import { Box, Button, descriptors, Icon, localizationKeys, NotificationBadge } from '../../customizables';
import { OrganizationPreview, PersonalWorkspacePreview, withAvatarShimmer } from '../../elements';
import { useDelayedVisibility, usePrefersReducedMotion } from '../../hooks';
import { Selector } from '../../icons';
import type { PropsOfComponent } from '../../styledSystem';
import type { PropsOfComponent, ThemableCssProp } from '../../styledSystem';
import { animations } from '../../styledSystem';
import { organizationListParams } from './utils';

type OrganizationSwitcherTriggerProps = PropsOfComponent<typeof Button> & {
isOpen: boolean;
Expand All@@ -23,7 +31,7 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
elementDescriptor={descriptors.organizationSwitcherTrigger}
variant='ghost'
colorScheme='neutral'
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0` }), sx]}
sx={[t => ({ minHeight: 0, padding: `0 ${t.space.$2} 0 0`, position: 'relative' }), sx]}
ref={ref}
{...rest}
>
Expand All@@ -49,6 +57,9 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
}
/>
)}

<NotificationCountBadge />

<Icon
elementDescriptor={descriptors.organizationSwitcherTriggerIcon}
icon={Selector}
Expand All@@ -58,3 +69,35 @@ export const OrganizationSwitcherTrigger = withAvatarShimmer(
);
}),
);

const NotificationCountBadge = () => {
const prefersReducedMotion = usePrefersReducedMotion();

/**
* Prefetch user invitations and suggestions
*/
const { userInvitations, userSuggestions } = useCoreOrganizationList(organizationListParams);
const notificationCount = (userInvitations.count || 0) + (userSuggestions.count || 0);
const showNotification = useDelayedVisibility(notificationCount > 0, 350) || false;

const enterExitAnimation: ThemableCssProp = t => ({
animation: prefersReducedMotion
? 'none'
: `${notificationCount ? animations.notificationAnimation : animations.outAnimation} ${
t.transitionDuration.$textField
} ${t.transitionTiming.$slowBezier} 0s 1 normal forwards`,
});

return (
<Box
sx={t => ({
position: 'relative',
width: t.sizes.$4,
height: t.sizes.$4,
marginLeft: `${t.space.$2}`,
})}
>
{showNotification && <NotificationBadge sx={enterExitAnimation}>{notificationCount}</NotificationBadge>}
</Box>
);
};
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import type { MembershipRole } from '@clerk/types';
import { describe } from '@jest/globals';

import { render } from '../../../../testUtils';
import { render, runFakeTimers, waitFor } from '../../../../testUtils';
import { bindCreateFixtures } from '../../../utils/test/createFixtures';
import { OrganizationSwitcher } from '../OrganizationSwitcher';
import { createFakeUserOrganizationInvitation, createFakeUserOrganizationSuggestion } from './utlis';
Expand DownExpand Up@@ -42,6 +42,37 @@ describe('OrganizationSwitcher', () => {
});
});

describe('OrganizationSwitcherTrigger', () => {
it('shows the counter for pending suggestions and invitations', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withUser({ email_addresses: ['test@clerk.dev'] });
});

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 2,
}),
);

fixtures.clerk.user?.getOrganizationSuggestions.mockReturnValueOnce(
Promise.resolve({
data: [],
total_count: 3,
}),
);

await runFakeTimers(async () => {
const { getByText } = render(<OrganizationSwitcher />, { wrapper });

await waitFor(() => {
expect(getByText('5')).toBeInTheDocument();
});
});
});
});

describe('OrganizationSwitcherPopover', () => {
it('opens the organization switcher popover when clicked', async () => {
const { wrapper, props } = await createFixtures(f => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,6 +262,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'qrCodeContainer',

'badge',
'notificationBadge',
'button',
'providerIcon',
// Decide if we want to keep the keys as camel cased in HTML as well,
Expand Down
4 changes: 4 additions & 0 deletions packages/clerk-js/src/ui/customizables/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,10 @@ export const Badge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitive
defaultDescriptor: descriptors.badge,
});

export const NotificationBadge = makeCustomizable(makeLocalizable(sanitizeDomProps(Primitives.NotificationBadge)), {
defaultDescriptor: descriptors.notificationBadge,
});

export const Table = makeCustomizable(sanitizeDomProps(Primitives.Table));
export const Thead = makeCustomizable(sanitizeDomProps(Primitives.Thead));
export const Tbody = makeCustomizable(sanitizeDomProps(Primitives.Tbody));
Expand Down
5 changes: 5 additions & 0 deletions packages/clerk-js/src/ui/hooks/useDelayedVisibility.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { useEffect, useState } from 'react';

/**
* Utility hook for delaying mounting of components for enter and exit animations.
* Delays to update the state when is switched from/to undefined.
* Immediate change for in-between changes
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

export function useDelayedVisibility<T>(valueToDelay: T, delayInMs: number) {
const [isVisible, setVisible] = useState<T | undefined>();

Expand Down
49 changes: 49 additions & 0 deletions packages/clerk-js/src/ui/primitives/NotificationBadge.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import type { PropsOfComponent, StyleVariants } from '../styledSystem';
import { common, createCssVariables, createVariants } from '../styledSystem';
import { Flex } from './Flex';

const vars = createCssVariables('accent', 'bg');

const { applyVariants, filterProps } = createVariants(theme => ({
base: {
color: vars.accent,
backgroundColor: vars.bg,
borderRadius: theme.radii.$sm,
height: theme.space.$4,
minWidth: theme.space.$4,
padding: `${theme.space.$0x5}`,
display: 'inline-flex',
},
variants: {
textVariant: { ...common.textVariants(theme) },
colorScheme: {
primary: {
[vars.accent]: theme.colors.$colorTextOnPrimaryBackground,
[vars.bg]: theme.colors.$primary500,
},
},
},
defaultVariants: {
colorScheme: 'primary',
textVariant: 'extraSmallRegular',
},
}));

// @ts-ignore
export type NotificationBadgeProps = PropsOfComponent<typeof Flex> & StyleVariants<typeof applyVariants>;

export const NotificationBadge = (props: NotificationBadgeProps) => {
Comment thread
nikosdouvlis marked this conversation as resolved.
return (
<Flex
{...filterProps(props)}
center
as='span'
css={[
applyVariants(props),
{
lineHeight: 0,
},
]}
/>
);
};
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,3 +26,4 @@ export * from './Tbody';
export * from './Tr';
export * from './Th';
export * from './Td';
export * from './NotificationBadge';
18 changes: 18 additions & 0 deletions packages/clerk-js/src/ui/styledSystem/animations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,23 @@ const inAnimation = keyframes`
}
`;

const notificationAnimation = keyframes`
0% {
opacity: 0;
transform: translateY(5px) scale(.5);
}

50% {
opacity: 1;
transform: translateY(0px) scale(1.2);
}

100% {
opacity: 1;
transform: translateY(0px) scale(1);
}
`;

const outAnimation = keyframes`
20% {
opacity: 1;
Expand DownExpand Up@@ -102,4 +119,5 @@ export const animations = {
navbarSlideIn,
inAnimation,
outAnimation,
notificationAnimation,
};
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -418,6 +418,7 @@ export type ElementsConfig = {

// default descriptors
badge: WithOptions<'primary' | 'actionRequired', never, never>;
notificationBadge: WithOptions<never, never, never>;
button: WithOptions<never, LoadingState, never>;
providerIcon: WithOptions<OAuthProvider | Web3Provider, never, never>;
};
Expand Down