Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/eighty-cobras-matter.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
'@clerk/clerk-js': patch
'@clerk/backend': patch
'@clerk/shared': patch
'@clerk/clerk-react': patch
---

Apply deprecation warnings for @clerk/types:

- `orgs` jwt claims
- `apiKey`
- `frontendApi`
- `redirect_url`
- `password`
- `generateSignature`
- `afterSwitchOrganizationUrl`
- `profileImageUrl`
2 changes: 1 addition & 1 deletion packages/backend/src/redirections.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ export function redirect({ redirectAdapter, signUpUrl, signInUrl, frontendApi, p
if (!frontendApi) {
frontendApi = parsePublishableKey(publishableKey)?.frontendApi;
} else {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

const accountsBaseUrl = buildAccountsBaseUrl(frontendApi);
Expand Down
9 changes: 9 additions & 0 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type { ActClaim, JwtPayload, ServerGetToken, ServerGetTokenOptions } from '@clerk/types';

import type { Organization, Session, User } from '../api';
Expand DownExpand Up@@ -80,6 +81,10 @@ export function signedInAuthObject(
} = sessionClaims;
const { apiKey, secretKey, apiUrl, apiVersion, token, session, user, organization } = options;

if (apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

const { sessions } = createBackendApiClient({
apiKey,
secretKey,
Expand DownExpand Up@@ -110,6 +115,10 @@ export function signedInAuthObject(
}

export function signedOutAuthObject(debugData?: AuthObjectDebugData): SignedOutAuthObject {
if (debugData?.apiKey) {
deprecated('apiKey', 'Use `secretKey` instead.');
}

return {
sessionClaims: null,
sessionId: null,
Expand Down
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/interstitial.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ export type LoadInterstitialOptions = {

export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions, 'apiUrl'>) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -135,7 +135,7 @@ export function loadInterstitialFromLocal(options: Omit<LoadInterstitialOptions,
// TODO: Add caching to Interstitial
export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}
if (options.pkgVersion) {
deprecated('pkgVersion', 'Use `clerkJSVersion` instead.');
Expand DownExpand Up@@ -164,7 +164,7 @@ export async function loadInterstitialFromBAPI(options: LoadInterstitialOptions)

export function buildPublicInterstitialUrl(options: LoadInterstitialOptions) {
if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

options.frontendApi = parsePublishableKey(options.publishableKey)?.frontendApi || options.frontendApi || '';
Expand Down
8 changes: 8 additions & 0 deletions packages/backend/src/tokens/jwt/verifyJwt.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecatedObjectProperty } from '@clerk/shared';
import type { Jwt, JwtPayload } from '@clerk/types';

// DO NOT CHANGE: Runtime needs to be imported as a default export so that we can stub its dependencies with Sinon.js
Expand DownExpand Up@@ -85,6 +86,13 @@ export function decodeJwt(token: string): Jwt {
const payload = JSON.parse(decoder.decode(base64url.parse(rawPayload, { loose: true })));
const signature = base64url.parse(rawSignature, { loose: true });

deprecatedObjectProperty(
payload,
'orgs',
'Add orgs to your session token using the "user.organizations" shortcode in JWT Templates instead.',
'decodeJwt:orgs',
);

return {
header,
payload,
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ export async function authenticateRequest(options: AuthenticateRequestOptions):
const { cookies, headers, searchParams } = buildRequest(options?.request);

if (options.frontendApi) {
deprecated('frontentApi', 'Use `publishableKey` instead.');
deprecated('frontendApi', 'Use `publishableKey` instead.');
}

if (options.apiKey) {
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,6 +245,8 @@ export default class Clerk implements ClerkInterface {
this.#proxyUrl = options?.proxyUrl;

if (isLegacyFrontendApiKey(key)) {
deprecated('frontendApi', 'Use `publishableKey` instead.');

if (!validateFrontendApi(key)) {
errorThrower.throwInvalidFrontendApiError({ key });
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,11 @@ import type {
MembershipRole,
OrganizationMembershipJSON,
OrganizationMembershipResource,
PublicUserData,
} from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { convertPageToOffset } from '../../utils/pagesToOffset';
import { BaseResource, Organization, OrganizationPublicUserData } from './internal';
import { BaseResource, Organization, PublicUserData } from './internal';

export class OrganizationMembership extends BaseResource implements OrganizationMembershipResource {
id!: string;
Expand DownExpand Up@@ -105,7 +104,7 @@ export class OrganizationMembership extends BaseResource implements Organization
this.organization = new Organization(data.organization);
this.publicMetadata = data.public_metadata;
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
this.role = data.role;
this.createdAt = unixEpochToDate(data.created_at);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource, PublicUserData } from '@clerk/types';
import type { OrganizationInvitationStatus, OrganizationMembershipRequestResource } from '@clerk/types';
import type { OrganizationMembershipRequestJSON } from '@clerk/types';

import { unixEpochToDate } from '../../utils/date';
import { BaseResource, OrganizationPublicUserData } from './internal';
import { BaseResource, PublicUserData } from './internal';

export class OrganizationMembershipRequest extends BaseResource implements OrganizationMembershipRequestResource {
id!: string;
Expand DownExpand Up@@ -37,7 +37,7 @@ export class OrganizationMembershipRequest extends BaseResource implements Organ
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
if (data.public_user_data) {
this.publicUserData = new OrganizationPublicUserData(data.public_user_data);
this.publicUserData = new PublicUserData(data.public_user_data);
}
}
return this;
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { deprecatedProperty } from '@clerk/shared';
import type { PublicUserData } from '@clerk/types';
import type { PublicUserData as IPublicUserData } from '@clerk/types';
import type { PublicUserDataJSON } from '@clerk/types';

export class OrganizationPublicUserData implements PublicUserData {
export class PublicUserData implements IPublicUserData {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why are we renaming this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the publicUserData property is the same for all Resources (eg OrganizationMembership , Session), so there is no need to create a separate class for each resource.

firstName!: string | null;
lastName!: string | null;
/**
Expand DownExpand Up@@ -33,4 +33,4 @@ export class OrganizationPublicUserData implements PublicUserData {
}
}

deprecatedProperty(OrganizationPublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
deprecatedProperty(PublicUserData, 'profileImageUrl', 'Use `imageUrl` instead.');
11 changes: 8 additions & 3 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import { is4xxError } from '@clerk/shared';
import { deepSnakeToCamel, runWithExponentialBackOff } from '@clerk/shared';
import { runWithExponentialBackOff } from '@clerk/shared';
import type {
ActJWTClaim,
GetToken,
GetTokenOptions,
PublicUserData,
SessionJSON,
SessionResource,
SessionStatus,
Expand All@@ -15,6 +14,7 @@ import type {
import { unixEpochToDate } from '../../utils/date';
import { eventBus, events } from '../events';
import { SessionTokenCache } from '../tokenCache';
import { PublicUserData } from './internal';
import { BaseResource, Token, User } from './internal';

export class Session extends BaseResource implements SessionResource {
Expand DownExpand Up@@ -138,8 +138,13 @@ export class Session extends BaseResource implements SessionResource {
this.createdAt = unixEpochToDate(data.created_at);
this.updatedAt = unixEpochToDate(data.updated_at);
this.user = new User(data.user);
this.publicUserData = deepSnakeToCamel(data.public_user_data) as PublicUserData;

if (data.public_user_data) {
this.publicUserData = new PublicUserData(data.public_user_data);
}
Comment thread
dimkl marked this conversation as resolved.

this.lastActiveToken = data.last_active_token ? new Token(data.last_active_token) : null;

return this;
}

Expand Down
7 changes: 3 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ import type {
SignInSecondFactor,
SignInStartMagicLinkFlowParams,
SignInStatus,
UserData,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand All@@ -37,7 +36,7 @@ import {
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
import { BaseResource, Verification } from './internal';
import { BaseResource, UserData, Verification } from './internal';

export class SignIn extends BaseResource implements SignInResource {
pathRoot = '/client/sign_ins';
Expand All@@ -51,7 +50,7 @@ export class SignIn extends BaseResource implements SignInResource {
secondFactorVerification: VerificationResource = new Verification(null);
identifier: string | null = null;
createdSessionId: string | null = null;
userData: UserData = {};
userData!: UserData;

constructor(data: SignInJSON | null = null) {
super();
Expand DownExpand Up@@ -255,7 +254,7 @@ export class SignIn extends BaseResource implements SignInResource {
this.firstFactorVerification = new Verification(data.first_factor_verification);
this.secondFactorVerification = new Verification(data.second_factor_verification);
this.createdSessionId = data.created_session_id;
this.userData = deepSnakeToCamel(data.user_data || {}) as UserData;
this.userData = new UserData(data.user_data);
}
return this;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { Poller } from '@clerk/shared';
import { deprecated, Poller } from '@clerk/shared';
import type {
AttemptEmailAddressVerificationParams,
AttemptPhoneNumberVerificationParams,
Expand DownExpand Up@@ -161,6 +161,10 @@ export class SignUp extends BaseResource implements SignUpResource {
attemptWeb3WalletVerification = async (params: AttemptWeb3WalletVerificationParams): Promise<SignUpResource> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this.attemptVerification({ signature, strategy: 'web3_metamask_signature' });
}
Expand Down
10 changes: 10 additions & 0 deletions packages/clerk-js/src/core/resources/User.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import { deprecatedProperty } from '@clerk/shared';
import type {
BackupCodeJSON,
Expand DownExpand Up@@ -154,6 +155,9 @@ export class User extends BaseResource implements UserResource {

createExternalAccount = async (params: CreateExternalAccountParams): Promise<ExternalAccountResource> => {
const { strategy, redirectUrl, additionalScopes, redirect_url } = params || {};
if (redirect_url) {
deprecated('redirect_url', 'Use `redirectUrl` instead.');
}

const json = (
await BaseResource._fetch<ExternalAccountJSON>({
Expand DownExpand Up@@ -216,6 +220,12 @@ export class User extends BaseResource implements UserResource {
};

update = (params: UpdateUserParams): Promise<UserResource> => {
if (params.password) {
deprecated(
'password',
'This will be removed in the next major version. Please use `updatePassword(params)` instead.',
);
}
return this._basePatch({
body: normalizeUnsafeMetadata(params),
});
Expand Down
32 changes: 32 additions & 0 deletions packages/clerk-js/src/core/resources/UserData.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
import { deprecatedProperty } from '@clerk/shared';
import type { UserData as IUserData } from '@clerk/types';
import type { UserDataJSON } from '@clerk/types';

export class UserData implements IUserData {
firstName?: string;
lastName?: string;
/**
* @deprecated Use `imageUrl` instead.
*/
profileImageUrl?: string;
imageUrl?: string;
hasImage?: boolean;

constructor(data: UserDataJSON) {
this.fromJSON(data);
}

protected fromJSON(data: UserDataJSON | null): this {
if (data) {
this.firstName = data.first_name;
this.lastName = data.last_name;
this.profileImageUrl = data.profile_image_url;
this.imageUrl = data.image_url;
this.hasImage = data.has_image;
}

return this;
}
}

deprecatedProperty(UserData, 'profileImageUrl', 'Use `imageUrl` instead.');
5 changes: 5 additions & 0 deletions packages/clerk-js/src/core/resources/Web3Wallet.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { deprecated } from '@clerk/shared';
import type {
AttemptWeb3WalletVerificationParams,
PrepareWeb3WalletVerificationParams,
Expand DownExpand Up@@ -37,6 +38,10 @@ export class Web3Wallet extends BaseResource implements Web3WalletResource {
attemptVerification = (params: AttemptWeb3WalletVerificationParams): Promise<this> => {
const { signature, generateSignature } = params || {};

if (generateSignature) {
deprecated('generateSignature', 'Use signature field instead.');
}

if (signature) {
return this._basePost<Web3WalletJSON>({
action: 'attempt_verification',
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ OrganizationMembership {
"publicMetadata": {
"foo": "bar",
},
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ OrganizationMembershipRequest {
"id": "test_id",
"organizationId": "test_org_id",
"pathRoot": "",
"publicUserData": OrganizationPublicUserData {
"publicUserData": PublicUserData {
"firstName": "test_first_name",
"hasImage": true,
"identifier": "test@identifier.gr",
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,13 @@ export * from './OrganizationDomain';
export * from './OrganizationInvitation';
export * from './OrganizationMembership';
export * from './OrganizationMembershipRequest';
export * from './OrganizationPublicUserData';
export * from './OrganizationSuggestion';
export * from './SamlAccount';
export * from './Session';
export * from './PublicUserData';
export * from './SessionWithActivities';
export * from './SignIn';
export * from './UserData';
export * from './SignUp';
export * from './Token';
export * from './TOTP';
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { snakeToCamel } from '@clerk/shared';
import { deprecated, snakeToCamel } from '@clerk/shared';
import type { OrganizationResource, UserResource } from '@clerk/types';
import React, { useMemo } from 'react';

Expand DownExpand Up@@ -294,6 +294,7 @@ export const useOrganizationSwitcherContext = () => {

// Continue to support afterSwitchOrganizationUrl
if (ctx.afterSwitchOrganizationUrl) {
deprecated('afterSwitchOrganizationUrl', 'Use `afterSelectOrganizationUrl` or `afterSelectPersonalUrl`');
return navigate(ctx.afterSwitchOrganizationUrl);
}

Expand Down
Loading