fix(clerk-js): Re-initialize Client singleton instance on Client destroy by octoper · Pull Request #1913 · clerk/javascript

octoper · 2023-10-18T12:22:39Z

Description

This PR will assign the Client properties to the default values on destroy.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Packages affected

changeset-bot · 2023-10-18T12:22:43Z

🦋 Changeset detected

Latest commit: f78a0be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl

🔧 Could you add a unit test to assert this?

desiprisg

💯

nikosdouvlis · 2023-10-31T08:53:02Z

@octoper Can you please rebase on top of main so the new CICD changes are reflected on this PR?
Also, shall we include at least one e2e test that covers the changes made here?

octoper · 2023-10-31T10:56:57Z

@nikosdouvlis Do you mean the main-v4 branch right? Because this is a PR for the v4 branch.

LekoArts

Let's add a E2E test for this 👍

desiprisg

💯

dimkl · 2023-11-01T09:51:58Z

+ // @ts-expect-error This is a private method that we are mocking
+ BaseResource._fetch = jest.fn().mockReturnValue(
+ Promise.resolve({
+ response: clientObjectJSON,


❓ is this what the DELETE /client returns? Isn't a DeletedObject type returned?

No the DELETE /client returns a response with the following format
{ client: null, response: { ... } // this is a ClientObject }

…t class

…roy (#1913) * fix(clerk-js): Re-initialize Client singleton on Client destroy * fix(clerk-js): Assign default values instead of re-initializing Client class * chore(repo): Adds changeset * chore(repo): Adds changeset * chore(clerk-js): Fix typo in test * test(clerk-js): Added test for Client singleton destroy * test(clerk-js): Update tests for Client singleton * test(clerk-js): Update tests for Client singleton & created new fixtures (cherry picked from commit 93a6115)

…roy (#1913) (#2016) * fix(clerk-js): Re-initialize Client singleton on Client destroy * fix(clerk-js): Assign default values instead of re-initializing Client class * chore(repo): Adds changeset * chore(repo): Adds changeset * chore(clerk-js): Fix typo in test * test(clerk-js): Added test for Client singleton destroy * test(clerk-js): Update tests for Client singleton * test(clerk-js): Update tests for Client singleton & created new fixtures (cherry picked from commit 93a6115) Co-authored-by: Vaggelis Yfantis <vaggelisyfantis@gmail.com>

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from 6e01dd3 to 9aa3dedCompare October 18, 2023 12:22

clerk-cookie added the clerk-js label Oct 18, 2023

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from 9aa3ded to fa5e12eCompare October 18, 2023 12:36

octoper marked this pull request as ready for review October 18, 2023 12:44

octoper requested a review from a team as a code owner October 18, 2023 12:44

dimkl reviewed Oct 18, 2023
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/Client.ts Outdated

dimkl approved these changes Oct 18, 2023
View reviewed changes

desiprisg approved these changes Oct 19, 2023
View reviewed changes

dimkl assigned octoper Oct 19, 2023

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from 6a662f4 to 9e2970eCompare October 19, 2023 10:09

dimkl reviewed Oct 19, 2023
View reviewed changes

Comment threadpackages/clerk-js/src/core/clerk.test.ts Outdated

dimkl reviewed Oct 19, 2023
View reviewed changes

Comment threadpackages/clerk-js/src/core/clerk.test.ts Outdated

octoper marked this pull request as draft October 19, 2023 10:28

octoper changed the base branch from main to main-v4October 25, 2023 17:30

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from 2ed1ff5 to cf5fad2Compare October 25, 2023 17:30

octoper marked this pull request as ready for review October 25, 2023 17:41

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from cf5fad2 to 5375d0eCompare October 31, 2023 08:04

LekoArts changed the base branch from main-v4 to mainOctober 31, 2023 10:40

LekoArts requested a review from a teamOctober 31, 2023 10:40

octoper changed the base branch from main to main-v4October 31, 2023 10:55

LekoArts suggested changes Oct 31, 2023
View reviewed changes

octoper changed the base branch from main-v4 to mainOctober 31, 2023 11:52

clerk-cookie added nextjs react remix actions backend labels Oct 31, 2023

desiprisg approved these changes Nov 1, 2023
View reviewed changes

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from f3af7aa to cbe1981Compare November 1, 2023 09:49

dimkl reviewed Nov 1, 2023
View reviewed changes

dimkl self-requested a review November 1, 2023 09:54

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from 7e10332 to 420ed28Compare November 1, 2023 11:09

dimkl approved these changes Nov 1, 2023
View reviewed changes

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch 2 times, most recently from 921309c to 260f04dCompare November 2, 2023 08:23

LekoArts approved these changes Nov 2, 2023
View reviewed changes

octoper added 8 commits November 2, 2023 12:23

fix(clerk-js): Re-initialize Client singleton on Client destroy
93d3d9b

fix(clerk-js): Assign default values instead of re-initializing Clien…
5b83805
…t class

chore(repo): Adds changeset
043df61

chore(repo): Adds changeset
6fe157b

chore(clerk-js): Fix typo in test
0e77242

test(clerk-js): Added test for Client singleton destroy
0a58ff2

test(clerk-js): Update tests for Client singleton
f2b57ba

test(clerk-js): Update tests for Client singleton & created new fixtures
f78a0be

octoper force-pushed the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch from 260f04d to f78a0beCompare November 2, 2023 10:23

octoper enabled auto-merge November 2, 2023 10:23

octoper added this pull request to the merge queue Nov 2, 2023

Merged via the queue into main with commit 93a6115Nov 2, 2023

octoper deleted the vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked branch November 2, 2023 10:40

clerk-cookie mentioned this pull request Nov 2, 2023
fix(clerk-js): Re-initialize Client singleton instance on Client destroy (#1913) #2016
Merged

clerk-cookie mentioned this pull request Nov 3, 2023
Version Packages (alpha-v5) #2000
Merged

LekoArts mentioned this pull request Mar 13, 2024
fix(themes): Add tslib and @clerk/types as dependencies to @clerk/themes (#2665) #2987
Merged

LekoArts mentioned this pull request Aug 2, 2024
chore(repo): Correct changeset #3883
Merged

Navigation Menu

Uh oh!

fix(clerk-js): Re-initialize Client singleton instance on Client destroy - #1913

fix(clerk-js): Re-initialize Client singleton instance on Client destroy#1913
octoper merged 8 commits into
mainfrom
vaggelis/sdk-525-after-sign-out-clerkclientid-still-has-a-value-when-checked

octoper commented Oct 18, 2023•
edited
Loading

Uh oh!

changeset-botBot commented Oct 18, 2023•
edited
Loading

Uh oh!

Uh oh!

dimkl left a comment

Uh oh!

desiprisg left a comment

Uh oh!

Uh oh!

Uh oh!

nikosdouvlis commented Oct 31, 2023

Uh oh!

octoper commented Oct 31, 2023

Uh oh!

LekoArts left a comment

Uh oh!

desiprisg left a comment

Uh oh!

Uh oh!

dimklNov 1, 2023

Uh oh!

octoperNov 1, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

octoper commented Oct 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Packages affected

Uh oh!

changeset-botBot commented Oct 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

dimkl left a comment

Choose a reason for hiding this comment

Uh oh!

desiprisg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nikosdouvlis commented Oct 31, 2023

Uh oh!

octoper commented Oct 31, 2023

Uh oh!

LekoArts left a comment

Choose a reason for hiding this comment

Uh oh!

desiprisg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dimklNov 1, 2023

Choose a reason for hiding this comment

Uh oh!

octoperNov 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

octoper commented Oct 18, 2023•
edited
Loading

changeset-botBot commented Oct 18, 2023•
edited
Loading