Uh oh!
There was an error while loading. Please reload this page.
fix(shared): Remove "sideEffects" and fix postbuild script - #1974
Conversation
🦋 Changeset detectedLatest commit: 26d72e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
commented
Oct 30, 2023
!snapshot |
This comment was marked as outdated.
This comment was marked as outdated.
| "browser", | ||
| "callWithRetry", | ||
| "color", | ||
| "cookie", | ||
| "date", | ||
| "deprecated", | ||
| "error", | ||
| "file", | ||
| "globs", | ||
| "handleValueOrFn", | ||
| "isomorphicAtob", | ||
| "keys", | ||
| "loadScript", | ||
| "localStorageBroadcastChannel", | ||
| "poller", | ||
| "proxy", | ||
| "underscore", | ||
| "url", | ||
| "react" |
tmilewski
left a comment
There was a problem hiding this comment.
❓ I was wondering the same thing as @panteliselef. Are we able to nest them?
We'll need to define these additional directories in two places and a nested approach will make it more manageable.
- NPM Script:
cleanwill need to account for these generated files. - Turborepo: The generated files/dirs will also need to be listed in the
buildtaskoutputs.
As-is, they both only account for ./dist.
Thanks!
LekoArts
commented
Oct 31, 2023
This is a follow-up to #1950 so the functionality is not new and Turborepo does not need to be considered here as these are only package.json files for compat reasons |
nikosdouvlis
commented
Oct 31, 2023
We're not able to nest them as we've found that Expo does not respect the |
| "name": "@clerk/shared", | ||
| "version": "1.0.0", | ||
| "description": "Internal package utils used by the Clerk SDKs", | ||
| "sideEffects": false, |
There was a problem hiding this comment.
Did you notice any side-effects (pun intended) in regards to code pruning when removing this?
There was a problem hiding this comment.
Still all worked fine during bundling :)
…1983) * fix(clerk-expo,shared): Bundle shared in expo * Revert "fix(clerk-expo,shared): Bundle shared in expo" This reverts commit c1e0279. * fix(shared): Add files key and fix script * chore(repo): Linting * fix(shared): Add package.json to exports (cherry picked from commit a68eb30) Co-authored-by: Lennart <lekoarts@gmail.com>
Description
In the first commit I tried to bundle
@clerk/sharedinto Expo but that didn't completely work as we'd also need to bundle React or Clerk JS -- ugh :/So this PR adds the
filesand adjusts the subpaths script.I also removed the
sideEffects: falsesince tsup/esbuild complained that this package is not side-effects free. Which is true since some packages import shared chunks.This is a follow-up to #1950
Fixes SDK-884
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore