Uh oh!
There was an error while loading. Please reload this page.
chore(fastify): Drop deprecations - #1976
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 385e8e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Oct 30, 2023
| frontendApi: constants.FRONTEND_API, | ||
| }); | ||
| // TODO(@dimkl): use empty string for frontendApi until type is fixed in @clerk/backend to drop it | ||
| const interstitialHtmlPage = clerkClient.localInterstitial({ publishableKey, frontendApi: '' }); |
Contributor
There was a problem hiding this comment.
❓ oh is this required ? 😅
ContributorAuthor
There was a problem hiding this comment.
yes. Will be fixed in the @clerk/backend deprecations PR
anagstef
approved these changes
Oct 31, 2023
nikosdouvlis
approved these changes
Oct 31, 2023
dimkl
commented
Oct 31, 2023
ContributorAuthor
I will close this tomorrow as part of testing the |
dimklforce-pushed
the
sdk-782-drop-deprecations-fastify
branch
from
October 31, 2023 21:16
769dbf5 to
1a366d5Comparedimklforce-pushed
the
sdk-782-drop-deprecations-fastify
branch
from
November 1, 2023 09:22
1a366d5 to
385e8e2Comparedimkl
added this pull request to the merge queue
Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop deprecations. Migration steps:
CLERK_SECRET_KEYinstead ofCLERK_API_KEYenv variablesecretKeyinstead ofapiKeyCLERK_PUBLISHABLE_KEYinstead ofCLERK_FRONTEND_APIenv variablepublishableKeyinstead offrontendApiChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore