') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat(clerk-js): Enable element descriptors for active devices [SDK-859] by tmilewski · Pull Request #1994 · clerk/javascript · GitHub
Skip to content

feat(clerk-js): Enable element descriptors for active devices [SDK-859] - #1994

Merged
tmilewski merged 1 commit into
mainfrom
SDK-859
Nov 1, 2023
Merged

feat(clerk-js): Enable element descriptors for active devices [SDK-859]#1994
tmilewski merged 1 commit into
mainfrom
SDK-859

Conversation

@tmilewski

@tmilewskitmilewski commented Nov 1, 2023

Copy link
Copy Markdown
Member

Description

Adds the following appearance keys for "Active devices":

  • cl-activeDeviceListItem
  • cl-activeDeviceListItem__current
  • cl-activeDevice
  • cl-activeDevice__current

Before

Screenshot 2023-10-31 at 5 39 36 PM

After

Screenshot 2023-10-31 at 5 39 49 PM

SDK-859

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski
tmilewski requested a review from a teamNovember 1, 2023 00:45
@tmilewskitmilewski self-assigned this Nov 1, 2023
@changeset-bot

changeset-botBot commented Nov 1, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 582cc91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/backendPatch
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewskitmilewski changed the title feat(clerk-js): Enable element descriptors & ids for active devices [SDK-859]feat(clerk-js): Enable element descriptors for active devices [SDK-859]Nov 1, 2023
desiprisg
desiprisg approved these changes Nov 1, 2023
View reviewed changes

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should be on main-v4

@tmilewski
tmilewski changed the base branch from main to main-v4November 1, 2023 01:00
panteliselef
panteliselef suggested changes Nov 1, 2023
View reviewed changes

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this PR introduces commits from v5

@LekoArts
LekoArts changed the base branch from main-v4 to mainNovember 1, 2023 08:40
@LekoArts

LekoArts commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

@desiprisg No, we merge things into main by default, regardless if it needs to be backported or not

@tmilewski
tmilewski added this pull request to the merge queue Nov 1, 2023
@tmilewski
tmilewski removed this pull request from the merge queue due to a manual request Nov 1, 2023
@tmilewski
tmilewski added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 78fc5eeNov 1, 2023
@tmilewski
tmilewski deleted the SDK-859 branch November 1, 2023 14:51
@clerk-cookieclerk-cookie mentioned this pull request Nov 1, 2023
Merged
tmilewski added a commit that referenced this pull request Nov 1, 2023
@tmilewski
feat(clerk-js): Enable element descriptors & ids for active devices […
efef113
…SDK-859] (#1994)
(cherry picked from commit 78fc5ee)
@clerk-cookieclerk-cookie mentioned this pull request Nov 1, 2023
Merged
github-merge-queueBot pushed a commit that referenced this pull request Nov 1, 2023
@clerk-cookie@tmilewski
feat(clerk-js): Enable element descriptors & ids for active devices […
0f8aedd
…SDK-859] (#1994) (#2010)
(cherry picked from commit 78fc5ee)
Co-authored-by: Tom Milewski <me@tm.codes>
@LekoArtsLekoArts mentioned this pull request Mar 13, 2024
Merged
@LekoArtsLekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@dimkldimkldimkl approved these changes
@nikospapcomnikospapcomnikospapcom approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
@desiprisgdesiprisgdesiprisg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jstypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tmilewski@LekoArts@dimkl@nikospapcom@panteliselef@desiprisg@clerk-cookie