loadCryptoKeyFunction, jwksClient on clerk-sdk-node addition and fixes by igneel64 · Pull Request #2 · clerk/javascript

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 · 2022-01-13T14:13:14Z

Additions

feat(backend-core): Add injectable loadCryptoKeyFunction
fix(clerk-sdk-node): Add jwksClient as the loadCryptoKey capability
fix(clerk-sdk-node): Clerk Base is part of the singleton
fix(clerk-sdk-node): Revisit middleware and instance tests
fix(clerk-sdk-node): deepmerge fetcher options

Notes

As discussed with @chanioxaris . We chose here to pass the public key as a CryptoKey from any external function like loadCryptoKey.
That is because there were a few issues with public key parsing etc.

As a next step or an alternative, we can use the loadCryptoKey as loadPublicKey and just return a public key as a string.

fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 · 2022-01-13T14:31:13Z

 "@peculiar/webcrypto": "^1.2.3",
 "camelcase-keys": "^6.2.2",
 "cookies": "^0.8.0",
+ "deepmerge": "^4.2.2",


This was introduced as a fix for merging supplied httpOptions.

igneel64 · 2022-01-13T14:31:56Z

 expect(allowlistIdentifiers2).toBe(allowlistIdentifiers);
 });
-
-test('clients getter returns a Client API instance', () => {


These tests about instance types seemed superficial. If anyone has an objection we can restore them.

SokratisVidros · 2022-01-13T14:40:15Z

 importKeyFunction: ImportKeyFunction;
 verifySignatureFunction: VerifySignatureFunction;
 decodeBase64Function: DecodeBase64Function;
+ loadCryptoKeyFunction?: LoadCryptoKeyFunction;


❓ What's the difference between the loadCryptoKeyFunction and the importKeyFunction?

Their docs:
@param{ImportKeyFunction}importKeyFunctionFunctiontoimportaPEM.Shouldhaveasimilarresulttocrypto.subtle.importKey @param{LoadCryptoKeyFunction}loadCryptoKeyFunctionFunctionloadaPKCryptoKeyfromthehostenvironment.UsedforJWKclientsetc.
Their difference is not so easily discernable for readers not familiar with the crypto operations we need to use for our jwt verification.
import is a reserved term coined as input a key in an external, portable format and take back a CryptoKey.
load does not have any special terminology like that and would allow injecting any kind of process that the client (of @clerk/backend-core) needs to do to provide a CryptoKey from his PK.

chanioxaris · 2022-01-14T07:46:53Z

 status: AuthStatus;
 session?: Session;
 interstitial?: string;
+ sessionClaims?: JWTPayload;


🔧 I will suggest to create a custom type for this, which will include the session ID and user ID for now and not depend on the JWT payload

chanioxaris · 2022-01-14T07:47:52Z

+ 'raw',
+ encoder.encode(
+ (
+ await jwksClient.getSigningKey(decoded.header.kid)


❓ What will happen if we can't find a key with the provided kid? Will it throw a descriptive error?

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

igneel64 requested review from SokratisVidros and chanioxaris January 13, 2022 14:13

feat: Add injectable loadCryptoKeyFunction
637b854
fix: Revisit middleware and instance tests, deepmerge fetcher options

igneel64 force-pushed the load_pk_injected_method branch from d1ea736 to 637b854Compare January 13, 2022 14:15

igneel64 commented Jan 13, 2022
View reviewed changes

SokratisVidros approved these changes Jan 13, 2022
View reviewed changes

chanioxaris reviewed Jan 14, 2022
View reviewed changes

chore(clerk-sdk-node): Some latest additions
7699fa9

igneel64 force-pushed the load_pk_injected_method branch from b7d555d to 7699fa9Compare January 18, 2022 09:10

Merge branch 'main' into load_pk_injected_method
f19f85b

igneel64 merged commit 54aaed3 into mainJan 18, 2022

SokratisVidros deleted the load_pk_injected_method branch February 3, 2022 12:53

github-actionsBot locked as resolved and limited conversation to collaborators Jun 11, 2023

Uh oh!

Conversation

igneel64 commented Jan 13, 2022

Additions

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

igneel64 commented Jan 13, 2022

Additions

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

igneel64 commented Jan 13, 2022

Additions

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation