Skip to content

chore(clerk-js): Replace Avatar preview in OrganizationProfileAvatarUploader with Upload Button - #2014

Merged
nikospapcom merged 1 commit into
mainfrom
nikospap/core-514-organization-avatar-in-createorganization-needs-to-be
Nov 6, 2023
Merged

chore(clerk-js): Replace Avatar preview in OrganizationProfileAvatarUploader with Upload Button#2014
nikospapcom merged 1 commit into
mainfrom
nikospap/core-514-organization-avatar-in-createorganization-needs-to-be

Conversation

@nikospapcom

@nikospapcomnikospapcom commented Nov 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Replacing AvatarPreview in OrganizationProfileAvatarUploader with upload button in CreateOrganizationForm to avoid layout shift

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

BEFORE

Screen.Recording.2023-11-02.at.10.48.22.AM.mov

AFTER

Screen.Recording.2023-11-06.at.9.38.02.AM.mov

Screenshot 2023-11-06 at 9 37 22 AM

@nikospapcom
nikospapcom requested a review from a team as a code ownerNovember 2, 2023 09:17
@changeset-bot

changeset-botBot commented Nov 2, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 50cdf7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikospapcomnikospapcom self-assigned this Nov 2, 2023
@nikospapcom
nikospapcomforce-pushed the nikospap/core-514-organization-avatar-in-createorganization-needs-to-be branch from d144469 to 990551fCompareNovember 3, 2023 08:01
panteliselef
panteliselef approved these changes Nov 3, 2023
View reviewed changes

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, i added a few minor comments

Comment threadpackages/clerk-js/src/ui/components/CreateOrganization/CreateOrganizationForm.tsx Outdated
Comment threadpackages/clerk-js/src/ui/components/CreateOrganization/CreateOrganizationForm.tsx Outdated
Comment threadpackages/clerk-js/src/ui/components/CreateOrganization/CreateOrganizationForm.tsx Outdated
@nikospapcom
nikospapcomforce-pushed the nikospap/core-514-organization-avatar-in-createorganization-needs-to-be branch 3 times, most recently from 127fdc0 to 1c2621fCompareNovember 6, 2023 07:36
@nikospapcom

nikospapcom commented Nov 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Great stuff, i added a few minor comments

Thanks for the review @panteliselef
I addressed you comments and update after screenshot/video accordingly

panteliselef
panteliselef suggested changes Nov 6, 2023
View reviewed changes

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught one minor thing, the stroke colour of the new svg we are introducting

Comment threadpackages/clerk-js/src/ui/icons/upload.svg Outdated
@nikospapcom
nikospapcomforce-pushed the nikospap/core-514-organization-avatar-in-createorganization-needs-to-be branch 2 times, most recently from 76d98ab to 3dce524CompareNovember 6, 2023 09:28
panteliselef
panteliselef approved these changes Nov 6, 2023
View reviewed changes

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nikospapcom
nikospapcomforce-pushed the nikospap/core-514-organization-avatar-in-createorganization-needs-to-be branch from 3dce524 to 50cdf7bCompareNovember 6, 2023 10:53
@nikospapcom
nikospapcom added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 8b40dc7Nov 6, 2023
@nikospapcom
nikospapcom deleted the nikospap/core-514-organization-avatar-in-createorganization-needs-to-be branch November 6, 2023 11:15
This was referenced Nov 6, 2023
Merged
Merged
nikospapcom added a commit that referenced this pull request Nov 9, 2023
@nikospapcom
chore(clerk-js): Replace Avatar preview in OrganizationProfileAvatarU…
4979618
…ploader with Upload Button (#2014)
(cherry picked from commit 8b40dc7)
github-merge-queueBot pushed a commit that referenced this pull request Nov 9, 2023
@clerk-cookie@nikospapcom
chore(clerk-js): Replace Avatar preview in OrganizationProfileAvatarU…
7ed0f81
…ploader with Upload Button (#2014) (#2090)
(cherry picked from commit 8b40dc7)
Co-authored-by: Papageorgiou Nikos <admin@nikospap.com>
@LekoArtsLekoArts mentioned this pull request Mar 13, 2024
Merged
@LekoArtsLekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chanioxarischanioxarisAwaiting requested review from chanioxaris
1 more reviewer
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nikospapcomnikospapcom

Labels

clerk-js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikospapcom@panteliselef@clerk-cookie