Uh oh!
There was an error while loading. Please reload this page.
chore(clerk-sdk-node): Drop deprecations - #2021
Conversation
🦋 Changeset detectedLatest commit: 8148ca3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
commented
Nov 3, 2023
Blocked by #2006 |
ae6352e to
56b4880Compare| ], | ||
| "scripts": { | ||
| "build": "npm run clean && tsup", | ||
| "postbuild": "node ../../scripts/subpath-workaround.mjs sdk-node", |
There was a problem hiding this comment.
@dimkl probably i'm missing some context, but why do we need this ? feel free to point me to an internal document if necessary.
There was a problem hiding this comment.
This will generate a packages/sdk-node/instance/ folder with a package.json to be used for subpath import of @clerk/clerk-sdk-node/instance. We have used it in @clerk/shared.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
56b4880 to
7f9ed77CompareUh oh!
There was an error while loading. Please reload this page.
1431f76 to
7abf631Compare7abf631 to
6abb21bCompareThe dropped setters: `setClerkApiVersion`, `setClerkHttpOptions`, `setClerkServerApiUrl`
6abb21b to
96a48a0CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
96a48a0 to
915c067CompareChanges: - drop subpath exports of /esm|cjs/instance
915c067 to
8148ca3CompareDismissing the "request changes" review as it's blocking Dimitris. I've confirmed that the requested changes have been made.
Description
Drop deprecations. Migration steps:
CLERK_SECRET_KEYinstead ofCLERK_API_KEYenv variablesecretKeyinstead ofapiKeyCLERK_PUBLISHABLE_KEYinstead ofCLERK_FRONTEND_APIenv variablepublishableKeyinstead offrontendApicreateClerkClientwith options to create a new clerkClient instead of usingthe following setters:
setClerkApiVersionsetClerkHttpOptionssetClerkServerApiUrlsetClerkApiKey@clerk/clerk-sdk-nodeinstead of@clerk/clerk-sdk-node/{cjs|esm}/instanceExtra:
Depends on the following PRs because of re-exports:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore