Uh oh!
There was an error while loading. Please reload this page.
chore(clerk-js): Replace text and email fields with Form.PlainInput - #2036
Conversation
🦋 Changeset detectedLatest commit: 92bfed2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| {...confirmationField.props} | ||
| required | ||
| /> | ||
| <Form.PlainInput {...confirmationField.props} /> |
There was a problem hiding this comment.
❓ Shouldn't this have the isRequired property?
There was a problem hiding this comment.
the hook above is defined as
constconfirmationField=useFormControl('deleteOrganizationConfirmation','',{
...
isRequired: true,
...
});so we are good
| </Form.ControlRow> | ||
| <Form.ControlRow elementId={slugField.id}> | ||
| <Form.Control | ||
| <Form.PlainInput |
There was a problem hiding this comment.
❓ This was required before, right?
There was a problem hiding this comment.
with the previous implementation of FormControl required would be overriden with required={isRequired} which in this situation is false. After checking the tests we had for ProfileSettings and the signature of organization.update i decided to remove this completely.
Uh oh!
There was an error while loading. Please reload this page.
| {...confirmationField.props} | ||
| required | ||
| /> | ||
| <Form.PlainInput {...confirmationField.props} /> |
There was a problem hiding this comment.
❓ Same question about required.
There was a problem hiding this comment.
isRequired is defined above in the hook, we should be good.
| <Form.Root onSubmit={addEmail}> | ||
| <Form.ControlRow elementId={emailField.id}> | ||
| <Form.Control | ||
| <Form.PlainInput |
There was a problem hiding this comment.
prop is coming from the hook
351082b to
76bffabCompare76bffab to
92bfed2Compare
Description
Droping the usage of Form.Control for simple text field with type
textoremail.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore