Uh oh!
There was an error while loading. Please reload this page.
feat(clerk-js,shared): Add a navigateWithError utility for SignIn - #2043
Merged
Conversation
🦋 Changeset detectedLatest commit: 2b5c1a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yourtallness
marked this pull request as draft
November 3, 2023 21:48
SokratisVidros
approved these changes
Nov 6, 2023
| export const isResetPasswordStrategy = (strategy: SignInStrategy | string | null | undefined) => | ||
| !!strategy && resetPasswordStrategies.includes(strategy as SignInStrategy); | ||
| export function navigateWithError(clerk: Clerk, navigate: (to: string) => Promise<unknown>, to: string, err) { |
Contributor
There was a problem hiding this comment.
I'd add this method as an internal method on Clerk Singleton. It feels like it's a better home with the current architecture.
yourtallnessforce-pushed
the
yourtallness/navigate_with_error
branch
from
November 6, 2023 13:58
a6b4569 to
ab672e7Compareyourtallness
marked this pull request as ready for review
November 6, 2023 14:00
yourtallnessforce-pushed
the
yourtallness/navigate_with_error
branch
2 times, most recently
from
November 6, 2023 23:41
58b8c53 to
8409a28CompareSokratisVidros
approved these changes
Nov 7, 2023
desiprisg
approved these changes
Nov 7, 2023
desiprisg
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's add a ticket to make a more uniform solution to these kind of problems, even if it gets backlogged for now.
nikosdouvlis
approved these changes
Nov 7, 2023
yourtallnessforce-pushed
the
yourtallness/navigate_with_error
branch
from
November 7, 2023 12:28
8409a28 to
2b5c1a6Compareyourtallness
added this pull request to the merge queue
Nov 7, 2023
yourtallness
commented
Nov 7, 2023
ContributorAuthor
https://linear.app/clerk/issue/SDK-914/determine-a-holistic-solution-for-redirecting-with-an-error |
yourtallness added a commit
that referenced
this pull request
Nov 7, 2023
) (cherry picked from commit 0d1052a)
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 8, 2023
) (#2074) * feat(clerk-js,shared): Add a navigateWithError utility for SignIn (#2043) (cherry picked from commit 0d1052a) * fix(clekr-js): Correctly return the reject return value --------- Co-authored-by: Mark Pitsilos <mark.pitsilos@gmail.com> Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore