Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Incorrect result counters in data tables - #2056
Merged
Conversation
🦋 Changeset detectedLatest commit: fb2df9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Nov 6, 2023
dimkl
left a comment
Contributor
There was a problem hiding this comment.
❓ Is it possible to add one test for each component?
nikosdouvlis
approved these changes
Nov 7, 2023
nikosdouvlis
left a comment
Member
There was a problem hiding this comment.
Great job @panteliselef - can we please add at least one unit test covering these?
Uh oh!
There was an error while loading. Please reload this page.
panteliselefforce-pushed
the
elef/SDK-893-incorrect-counts
branch
from
November 7, 2023 09:42
eb04b8d to
fb2df9dComparepanteliselef
added this pull request to the merge queue
Nov 7, 2023
This was referenced Nov 7, 2023
panteliselef added a commit
that referenced
this pull request
Nov 7, 2023
* fix(clerk-js): Incorrect result counters in data tables * test(clerk-js): Unit test for pagination counts (cherry picked from commit 64d3763)
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 7, 2023
* fix(clerk-js): Incorrect result counters in data tables (#2056) * fix(clerk-js): Incorrect result counters in data tables * test(clerk-js): Unit test for pagination counts (cherry picked from commit 64d3763) * chore(clerk-js): Import missing act This was caused by missing commit that was not backported --------- Co-authored-by: panteliselef <panteliselef@outlook.com>
panteliselef
commented
Nov 7, 2023
ContributorAuthor
!snapshot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues with incorrect values in table pagination as users select pages
Before
Page 2
After
Page 2
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore