chore(types): Drop deprecations by dimkl · Pull Request #2109 · clerk/javascript

dimkl · 2023-11-10T08:08:13Z

Description

Drop deprecations. Migration steps:

drop orgs jwt claim from session token
change type of auth param of withServerAuth() callback to AuthObject from ServerSideAuth in gatsby-clerk-plugin
- use auth.sessionClaims instead of auth.claims
- use AuthObject properties from auth
use publishableKey instead of frontendApi
use ClerkProviderOptionsWrapper type instead of IsomorphicClerkOptions

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Packages affected

changeset-bot · 2023-11-10T08:08:17Z

🦋 Changeset detected

Latest commit: eb4a21e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
gatsby-plugin-clerk	Major
@clerk/nextjs	Major
@clerk/clerk-react	Major
@clerk/remix	Major
@clerk/types	Major
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/backend	Patch
@clerk/clerk-js	Patch
@clerk/fastify	Patch
@clerk/clerk-sdk-node	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2023-11-16T17:35:27Z

- isSatellite: props.isSatellite || isTruthy(process.env.NEXT_PUBLIC_CLERK_IS_SATELLITE),
+ proxyUrl: props.proxyUrl || (process.env.NEXT_PUBLIC_CLERK_PROXY_URL as any), // added as any to cater issue with type resolution
+ domain: props.domain || (process.env.NEXT_PUBLIC_CLERK_DOMAIN as any), // added as any to cater issue with type resolution
+ isSatellite: props.isSatellite || (isTruthy(process.env.NEXT_PUBLIC_CLERK_IS_SATELLITE) as any), // added as any to cater issue with type resolution


@panteliselef i had to do this in order for the MultidomainAndOrProxy types to pass. let's discuss it tomorrow and see if we can simplify the type or fix the current issues.

dimkl · 2023-11-16T21:51:49Z

Moved localization related PRs to #2151

…Object` `AuthObject` is a kind of superset of `ServerSideAuth`. The only difference is that instead of `auth.claims` in `AuthObject` you need to use `auth.sessionClaims`

…oviderOptionsWrapper

dimkl added the v5-release label Nov 10, 2023

dimkl self-assigned this Nov 10, 2023

dimkl requested a review from a team as a code owner November 10, 2023 08:08

clerk-cookie added types nextjs react remix localizations gatsby labels Nov 10, 2023

dimkl commented Nov 10, 2023
View reviewed changes

Comment thread.changeset/long-beds-mate.md Outdated

dimkl force-pushed the sdk-782-drop-deprecations-shared branch from fe363d9 to e6c457fCompare November 10, 2023 09:09

dimkl force-pushed the sdk-782-drop-deprecations-types branch from 769e1c3 to 89d9c98Compare November 10, 2023 09:12

panteliselef suggested changes Nov 10, 2023
View reviewed changes

Comment threadpackages/nextjs/src/types.ts
Comment threadpackages/remix/src/client/types.ts

dimkl force-pushed the sdk-782-drop-deprecations-shared branch from e6c457f to cb0f046Compare November 10, 2023 10:40

dimkl force-pushed the sdk-782-drop-deprecations-types branch from 89d9c98 to 48c87b1Compare November 10, 2023 10:47

panteliselef approved these changes Nov 10, 2023
View reviewed changes

dimkl force-pushed the sdk-782-drop-deprecations-types branch 2 times, most recently from b05817b to 937338dCompare November 10, 2023 13:54

dimkl force-pushed the sdk-782-drop-deprecations-shared branch from cb0f046 to 2970cbaCompare November 13, 2023 15:53

dimkl force-pushed the sdk-782-drop-deprecations-types branch from 937338d to e013129Compare November 13, 2023 15:54

dimkl force-pushed the sdk-782-drop-deprecations-shared branch 2 times, most recently from 4cbb4c9 to 55612d2Compare November 13, 2023 18:32

nikosdouvlis approved these changes Nov 15, 2023
View reviewed changes

Comment thread.changeset/long-beds-mate.md Outdated

dimkl force-pushed the sdk-782-drop-deprecations-shared branch from 55612d2 to f052495Compare November 15, 2023 13:45

Base automatically changed from sdk-782-drop-deprecations-shared to mainNovember 15, 2023 13:58

dimkl force-pushed the sdk-782-drop-deprecations-types branch from e013129 to fd01ed2Compare November 15, 2023 14:27

dimkl enabled auto-merge November 15, 2023 14:27

dimkl disabled auto-merge November 15, 2023 14:27

dimkl force-pushed the sdk-782-drop-deprecations-types branch from fd01ed2 to e0107ddCompare November 15, 2023 15:05

dimkl enabled auto-merge November 15, 2023 15:05

dimkl force-pushed the sdk-782-drop-deprecations-types branch from e0107dd to c82f3aeCompare November 15, 2023 15:14

clerk-cookie added the expo label Nov 15, 2023

dimkl force-pushed the sdk-782-drop-deprecations-types branch 4 times, most recently from 2961583 to 6e7e3ecCompare November 15, 2023 23:49

clerk-cookie added the integration label Nov 15, 2023

dimkl force-pushed the sdk-782-drop-deprecations-types branch from 6e7e3ec to acafd5bCompare November 16, 2023 17:23

clerk-cookie added the retheme label Nov 16, 2023

dimkl force-pushed the sdk-782-drop-deprecations-types branch from acafd5b to 418ddc0Compare November 16, 2023 17:27

dimkl commented Nov 16, 2023
View reviewed changes

dimkl force-pushed the sdk-782-drop-deprecations-types branch from 418ddc0 to d5e3377Compare November 16, 2023 17:36

dimkl force-pushed the sdk-782-drop-deprecations-types branch from d5e3377 to cc78b25Compare November 16, 2023 21:55

clerk-cookie removed localizations retheme labels Nov 16, 2023

dimkl added 6 commits November 17, 2023 12:56

chore(types): Drop orgs claim
ca7dbd4

chore(gatsby-plugin-clerk,types): Replace ServerSideAuth with `Auth…
a451832
…Object` `AuthObject` is a kind of superset of `ServerSideAuth`. The only difference is that instead of `auth.claims` in `AuthObject` you need to use `auth.sessionClaims`

chore(types,clerk-react,nextjs): Drop frontendApi and apiKey
1fa220e

fix(clerk-expo): Fix building types
07681fd

chore(*): Drop export and replace IsomorphicClerkOptions with ClerkPr…
f730233
…oviderOptionsWrapper

chore(repo): Add changeset
eb4a21e

dimkl force-pushed the sdk-782-drop-deprecations-types branch from cc78b25 to eb4a21eCompare November 17, 2023 15:22

clerk-cookie removed the integration label Nov 17, 2023

dimkl added this pull request to the merge queue Nov 17, 2023

Merged via the queue into main with commit 2a22aadNov 17, 2023

dimkl deleted the sdk-782-drop-deprecations-types branch November 17, 2023 15:36

clerk-cookie mentioned this pull request Nov 17, 2023
Version Packages (alpha-v5) #2065
Merged

Navigation Menu

Uh oh!

chore(types): Drop deprecations - #2109

chore(types): Drop deprecations#2109
dimkl merged 6 commits into
mainfrom
sdk-782-drop-deprecations-types

dimkl commented Nov 10, 2023•
edited
Loading

Uh oh!

changeset-botBot commented Nov 10, 2023•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dimklNov 16, 2023

Uh oh!

dimkl commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dimkl commented Nov 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Packages affected

Uh oh!

changeset-botBot commented Nov 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dimklNov 16, 2023

Choose a reason for hiding this comment

Uh oh!

dimkl commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dimkl commented Nov 10, 2023•
edited
Loading

changeset-botBot commented Nov 10, 2023•
edited
Loading