Uh oh!
There was an error while loading. Please reload this page.
chore(clerk-js,nextjs,shared): Move devBrowser to shared - #2149
Merged
Conversation
🦋 Changeset detectedLatest commit: d868e42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimklforce-pushed
the
sdk-770-devBrowser-to-shared
branch
from
November 16, 2023 20:11
3fd33be to
f333569Comparenikosdouvlis
approved these changes
Nov 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
anagstef
suggested changes
Nov 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
dimklforce-pushed
the
sdk-770-devBrowser-to-shared
branch
from
November 16, 2023 20:55
f333569 to
d868e42Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move devBrowser utils to
@clerk/shared. Ideally we should only expose some getters/setters to handle the devBrowser in cookie/query-parameter/localStorage, but currently since there is multiple ways to access the cookie and the localStorage is browser related i kept exposing some constants from shared and left some code handling the specific cases.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore