') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat(backend,clerk-sdk-node): Drop create sms endpoint by Nikpolik · Pull Request #2165 · clerk/javascript · GitHub
Skip to content

feat(backend,clerk-sdk-node): Drop create sms endpoint - #2165

Merged
Nikpolik merged 2 commits into
mainfrom
nikpolik/drop-create-sms-endpoint
Nov 22, 2023
Merged

feat(backend,clerk-sdk-node): Drop create sms endpoint#2165
Nikpolik merged 2 commits into
mainfrom
nikpolik/drop-create-sms-endpoint

Conversation

@Nikpolik

@NikpolikNikpolik commented Nov 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Remove createSms functions from @clerk/backend and @clerk/sdk-node.

The equivalent /sms_messages Backend API endpoint will also be dropped in the future, since this feature will no longer be available for new instances.

For a brief period it will still be accessible for instances that have used it in the past 7
days (13-11-2023 to 20-11-2023).

New instances will get a 403 forbidden response if they try to access it.

@NikpolikNikpolik self-assigned this Nov 17, 2023
@changeset-bot

changeset-botBot commented Nov 17, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c76832e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@clerk/clerk-sdk-nodePatch
@clerk/backendMinor
gatsby-plugin-clerkPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/remixPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Nikpolik
Nikpolikforce-pushed the nikpolik/drop-create-sms-endpoint branch 3 times, most recently from a890c6d to ca21b16CompareNovember 20, 2023 12:41
@Nikpolik
Nikpolik marked this pull request as ready for review November 20, 2023 12:41
nikosdouvlis
nikosdouvlis approved these changes Nov 20, 2023
View reviewed changes

@nikosdouvlisnikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikpolik This looks good to me :)
If we haven't done that already, we need to add deprecation warnings to the methods in the release/v4 branch as well, letting our users know that these endpoints will be removed.

@Nikpolik
Nikpolikforce-pushed the nikpolik/drop-create-sms-endpoint branch from ca21b16 to 1c4cfa1CompareNovember 20, 2023 21:08
@Nikpolik

Nikpolik commented Nov 21, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@nikosdouvlis I added dba09d9 and will cherry pick this commit to release/v4 after merging!

@Nikpolik
Nikpolikforce-pushed the nikpolik/drop-create-sms-endpoint branch 2 times, most recently from 65d07ee to 6a6b1ccCompareNovember 21, 2023 09:21
SokratisVidros
SokratisVidros approved these changes Nov 21, 2023
View reviewed changes
Comment thread.changeset/slimy-windows-grab.md

Deprecate `createSMSMessage` and `SMSMessageApi` from `clerkClient`.

The equivalent `/sms_messages` Backend API endpoint will also be dropped in the future, since this feature will no longer be available for new instances.

@SokratisVidrosSokratisVidrosNov 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The equivalent `/sms_messages` Backend API endpoint will also be dropped in the future, since this feature will no longer be available for new instances.
The `/sms_messages` Backend API endpoint will also be dropped in the future since this feature will no longer be available for new Clerk instances.

@NikpolikNikpolikNov 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SokratisVidros I had enabled auto merge from yesterday and did not get a chance to update the copyright 😓

@NikpolikNikpolikNov 22, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its updated in #2184 which is for v4 release

Comment thread.changeset/eleven-bananas-joke.md
Nikos Polykandriotis added 2 commits November 22, 2023 12:37
Nikos Polykandriotis
feat(backend): Deprecate createSMSMessage
2837a5d
Nikos Polykandriotis
feat(backend,clerk-sdk-node): Drop create sms endpoint
c76832e
This feature is beeing dropped from the Backend API.
For a brief period it will still be available for instances that have used it in the past 7
days (13-11-2023 to 20-11-2023).
New instances will get a 403 forbidden response if they try to access it.
@Nikpolik
Nikpolikforce-pushed the nikpolik/drop-create-sms-endpoint branch from 6a6b1cc to c76832eCompareNovember 22, 2023 10:39
@Nikpolik
Nikpolik added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 4aaf510Nov 22, 2023
@Nikpolik
Nikpolik deleted the nikpolik/drop-create-sms-endpoint branch November 22, 2023 10:49
@clerk-cookieclerk-cookie mentioned this pull request Nov 22, 2023
Merged
@NikpolikNikpolik mentioned this pull request Nov 22, 2023
Merged
24 tasks
desiprisg pushed a commit that referenced this pull request Nov 23, 2023
Nikos Polykandriotis@desiprisg
feat(backend,clerk-sdk-node): Drop create sms endpoint (#2165)
97e62f6
* feat(backend): Deprecate createSMSMessage
* feat(backend,clerk-sdk-node): Drop create sms endpoint
This feature is beeing dropped from the Backend API.
For a brief period it will still be available for instances that have used it in the past 7
days (13-11-2023 to 20-11-2023).
New instances will get a 403 forbidden response if they try to access it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
+2 more reviewers
@SokratisVidrosSokratisVidrosSokratisVidros approved these changes
@dimkldimkldimkl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikpolikNikpolik

Labels

backendsdk-node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Nikpolik@SokratisVidros@nikosdouvlis@dimkl@clerk-cookie