Skip to content

fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226

Merged
panteliselef merged 7 commits into
mainfrom
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged

fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom
elef/fix-missing-isomorphic-clerk

Conversation

@panteliselef

@panteliselefpanteliselef commented Nov 28, 2023•
edited by dimkl
Loading

Copy link
Copy Markdown
Contributor

Description

SDK-1035

This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.

Before

const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated

After

const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.

Keep in mind you still need to check if Clerk has loaded in order to

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@changeset-bot

changeset-botBot commented Nov 28, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1eee5ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArtsLekoArts mentioned this pull request Nov 29, 2023
Closed
4 tasks
@panteliselefpanteliselef changed the title [WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef changed the title SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef marked this pull request as ready for review November 29, 2023 10:11
@octoper

octoper commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

clerk-cookie commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact

@clerk/shared

npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact

@clerk/themes

npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact

@clerk/types

npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact

@github-actions

github-actionsBot commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

⚠️ Changes detected under the ClerkJS ui directory!

Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**

Also, you may need to update the following files:

  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts

@panteliselef
panteliselefforce-pushed the elef/fix-missing-isomorphic-clerk branch from 0e0c835 to 1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef deleted the elef/fix-missing-isomorphic-clerk branch November 29, 2023 15:59
@clerk-cookieclerk-cookie mentioned this pull request Nov 29, 2023
Merged
@panteliselefpanteliselef mentioned this pull request Nov 29, 2023
Merged
24 tasks
panteliselef added a commit that referenced this pull request Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef mentioned this pull request Nov 29, 2023
Merged
24 tasks
github-merge-queueBot pushed a commit that referenced this pull request Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts mentioned this pull request Mar 13, 2024
Merged
@LekoArtsLekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski

@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(clerk-react): Missing methods and properties from IsomorphicClerk by panteliselef · Pull Request #2226 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226
Merged
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged
fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Nov 28, 2023•

edited by dimkl

Loading

Copy link


Copy Markdown

Contributor
Description
SDK-1035
This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.
Before
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated
After
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.
Keep in mind you still need to check if Clerk has loaded in order to
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Nov 28, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1eee5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LekoArtsLekoArts
mentioned this pull request
Nov 29, 2023

Closed

4 tasks
@panteliselefpanteliselef
changed the title
[WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef
changed the title
SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef
marked this pull request as ready for review
November 29, 2023 10:11
@octoper
octoper
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
!snapshot
@clerk-cookie
clerk-cookie
commented
Nov 29, 2023

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact
@github-actions
github-actionsBot
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@panteliselef
panteliselefforce-pushed
the
elef/fix-missing-isomorphic-clerk
branch
from
0e0c835 to
1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef
added this pull request to the merge queue
Nov 29, 2023

Merged
via the queue into
main
with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef
deleted the

elef/fix-missing-isomorphic-clerk

branch
November 29, 2023 15:59
@clerk-cookieclerk-cookie
mentioned this pull request
Nov 29, 2023
 Merged

@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
panteliselef added a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski
@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Missing methods and properties from IsomorphicClerk by panteliselef · Pull Request #2226 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226
Merged
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged
fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Nov 28, 2023•

edited by dimkl

Loading

Copy link


Copy Markdown

Contributor
Description
SDK-1035
This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.
Before
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated
After
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.
Keep in mind you still need to check if Clerk has loaded in order to
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Nov 28, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1eee5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LekoArtsLekoArts
mentioned this pull request
Nov 29, 2023

Closed

4 tasks
@panteliselefpanteliselef
changed the title
[WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef
changed the title
SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef
marked this pull request as ready for review
November 29, 2023 10:11
@octoper
octoper
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
!snapshot
@clerk-cookie
clerk-cookie
commented
Nov 29, 2023

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact
@github-actions
github-actionsBot
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@panteliselef
panteliselefforce-pushed
the
elef/fix-missing-isomorphic-clerk
branch
from
0e0c835 to
1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef
added this pull request to the merge queue
Nov 29, 2023

Merged
via the queue into
main
with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef
deleted the

elef/fix-missing-isomorphic-clerk

branch
November 29, 2023 15:59
@clerk-cookieclerk-cookie
mentioned this pull request
Nov 29, 2023
 Merged

@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
panteliselef added a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski
@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Missing methods and properties from IsomorphicClerk by panteliselef · Pull Request #2226 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226
Merged
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged
fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Nov 28, 2023•

edited by dimkl

Loading

Copy link


Copy Markdown

Contributor
Description
SDK-1035
This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.
Before
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated
After
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.
Keep in mind you still need to check if Clerk has loaded in order to
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Nov 28, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1eee5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LekoArtsLekoArts
mentioned this pull request
Nov 29, 2023

Closed

4 tasks
@panteliselefpanteliselef
changed the title
[WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef
changed the title
SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef
marked this pull request as ready for review
November 29, 2023 10:11
@octoper
octoper
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
!snapshot
@clerk-cookie
clerk-cookie
commented
Nov 29, 2023

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact
@github-actions
github-actionsBot
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@panteliselef
panteliselefforce-pushed
the
elef/fix-missing-isomorphic-clerk
branch
from
0e0c835 to
1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef
added this pull request to the merge queue
Nov 29, 2023

Merged
via the queue into
main
with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef
deleted the

elef/fix-missing-isomorphic-clerk

branch
November 29, 2023 15:59
@clerk-cookieclerk-cookie
mentioned this pull request
Nov 29, 2023
 Merged

@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
panteliselef added a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski
@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(clerk-react): Missing methods and properties from IsomorphicClerk by panteliselef · Pull Request #2226 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226
Merged
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged
fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Nov 28, 2023•

edited by dimkl

Loading

Copy link


Copy Markdown

Contributor
Description
SDK-1035
This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.
Before
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated
After
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.
Keep in mind you still need to check if Clerk has loaded in order to
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Nov 28, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1eee5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LekoArtsLekoArts
mentioned this pull request
Nov 29, 2023

Closed

4 tasks
@panteliselefpanteliselef
changed the title
[WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef
changed the title
SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef
marked this pull request as ready for review
November 29, 2023 10:11
@octoper
octoper
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
!snapshot
@clerk-cookie
clerk-cookie
commented
Nov 29, 2023

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact
@github-actions
github-actionsBot
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@panteliselef
panteliselefforce-pushed
the
elef/fix-missing-isomorphic-clerk
branch
from
0e0c835 to
1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef
added this pull request to the merge queue
Nov 29, 2023

Merged
via the queue into
main
with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef
deleted the

elef/fix-missing-isomorphic-clerk

branch
November 29, 2023 15:59
@clerk-cookieclerk-cookie
mentioned this pull request
Nov 29, 2023
 Merged

@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
panteliselef added a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski
@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Missing methods and properties from IsomorphicClerk by panteliselef · Pull Request #2226 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226
Merged
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged
fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Nov 28, 2023•

edited by dimkl

Loading

Copy link


Copy Markdown

Contributor
Description
SDK-1035
This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.
Before
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated
After
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.
Keep in mind you still need to check if Clerk has loaded in order to
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Nov 28, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1eee5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LekoArtsLekoArts
mentioned this pull request
Nov 29, 2023

Closed

4 tasks
@panteliselefpanteliselef
changed the title
[WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef
changed the title
SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef
marked this pull request as ready for review
November 29, 2023 10:11
@octoper
octoper
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
!snapshot
@clerk-cookie
clerk-cookie
commented
Nov 29, 2023

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact
@github-actions
github-actionsBot
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@panteliselef
panteliselefforce-pushed
the
elef/fix-missing-isomorphic-clerk
branch
from
0e0c835 to
1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef
added this pull request to the merge queue
Nov 29, 2023

Merged
via the queue into
main
with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef
deleted the

elef/fix-missing-isomorphic-clerk

branch
November 29, 2023 15:59
@clerk-cookieclerk-cookie
mentioned this pull request
Nov 29, 2023
 Merged

@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
panteliselef added a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski
@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Missing methods and properties from IsomorphicClerk by panteliselef · Pull Request #2226 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226
Merged
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged
fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Nov 28, 2023•

edited by dimkl

Loading

Copy link


Copy Markdown

Contributor
Description
SDK-1035
This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.
Before
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated
After
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.
Keep in mind you still need to check if Clerk has loaded in order to
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Nov 28, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1eee5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LekoArtsLekoArts
mentioned this pull request
Nov 29, 2023

Closed

4 tasks
@panteliselefpanteliselef
changed the title
[WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef
changed the title
SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef
marked this pull request as ready for review
November 29, 2023 10:11
@octoper
octoper
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
!snapshot
@clerk-cookie
clerk-cookie
commented
Nov 29, 2023

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact
@github-actions
github-actionsBot
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@panteliselef
panteliselefforce-pushed
the
elef/fix-missing-isomorphic-clerk
branch
from
0e0c835 to
1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef
added this pull request to the merge queue
Nov 29, 2023

Merged
via the queue into
main
with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef
deleted the

elef/fix-missing-isomorphic-clerk

branch
November 29, 2023 15:59
@clerk-cookieclerk-cookie
mentioned this pull request
Nov 29, 2023
 Merged

@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
panteliselef added a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski
@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(clerk-react): Missing methods and properties from IsomorphicClerk by panteliselef · Pull Request #2226 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Missing methods and properties from IsomorphicClerk - #2226
Merged
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged
fix(clerk-react): Missing methods and properties from IsomorphicClerk#2226
panteliselef merged 7 commits into
mainfrom 
elef/fix-missing-isomorphic-clerk
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Nov 28, 2023•

edited by dimkl

Loading

Copy link


Copy Markdown

Contributor
Description
SDK-1035
This PR aims to bring IsomorphicClerk in sync with the clerk singleton and the LoadedClerk interface.
IsomorphicClerk now extends from LoadedClerk in order to avoid missing methods without typescript errors.
Before
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// ^ This would throw an error as `buildSignUpUrl` was not defined when IsomorphicClerk was instantiated
After
const{ loaded, buildSignUpUrl }=useClerk();if(loaded)buildSignUpUrl(...)// Works as expected and a url is returned.
Keep in mind you still need to check if Clerk has loaded in order to
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@changeset-bot
changeset-botBot
commented
Nov 28, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1eee5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 7 packages
NameType
@clerk/clerk-jsPatch
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LekoArtsLekoArts
mentioned this pull request
Nov 29, 2023

Closed

4 tasks
@panteliselefpanteliselef
changed the title
[WIP] fix(clerk-react): Missing methods and properties from IsomorphicClerkSDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselefpanteliselef
changed the title
SDK-1035 fix(clerk-react): Missing methods and properties from IsomorphicClerkfix(clerk-react): Missing methods and properties from IsomorphicClerkNov 29, 2023
@panteliselef
panteliselef
marked this pull request as ready for review
November 29, 2023 10:11
@octoper
octoper
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
!snapshot
@clerk-cookie
clerk-cookie
commented
Nov 29, 2023

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v24602f7
@clerk/chrome-extension1.0.1-snapshot.v24602f7
@clerk/clerk-js5.0.1-snapshot.v24602f7
@clerk/clerk-expo1.0.1-snapshot.v24602f7
@clerk/fastify1.0.1-snapshot.v24602f7
gatsby-plugin-clerk5.0.1-snapshot.v24602f7
@clerk/localizations2.0.1-snapshot.v24602f7
@clerk/nextjs5.0.1-snapshot.v24602f7
@clerk/clerk-react5.0.1-snapshot.v24602f7
@clerk/remix4.0.1-snapshot.v24602f7
@clerk/clerk-sdk-node5.0.1-snapshot.v24602f7
@clerk/shared2.0.1-snapshot.v24602f7
@clerk/themes2.0.1-snapshot.v24602f7
@clerk/types4.0.1-snapshot.v24602f7
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v24602f7 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v24602f7 --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v24602f7 --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v24602f7 --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v24602f7 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v24602f7 --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v24602f7 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v24602f7 --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v24602f7 --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v24602f7 --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v24602f7 --save-exact
@github-actions
github-actionsBot
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@panteliselef
panteliselefforce-pushed
the
elef/fix-missing-isomorphic-clerk
branch
from
0e0c835 to
1eee5edCompareNovember 29, 2023 15:42
@panteliselef
panteliselef
added this pull request to the merge queue
Nov 29, 2023

Merged
via the queue into
main
with commit 6e54b1bNov 29, 2023
@panteliselef
panteliselef
deleted the

elef/fix-missing-isomorphic-clerk

branch
November 29, 2023 15:59
@clerk-cookieclerk-cookie
mentioned this pull request
Nov 29, 2023
 Merged

@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
panteliselef added a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
8fac836
…#2226)
@panteliselefpanteliselef
mentioned this pull request
Nov 29, 2023
 Merged

24 tasks
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 29, 2023
@panteliselef
fix(clerk-react): Missing methods and properties from IsomorphicClerk (…
7130db0
…#2226) (#2233)
@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@dimkldimklAwaiting requested review from dimkl

Assignees

@tmilewskitmilewski
@panteliselefpanteliselef

Labels

clerk-jsreacttypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@panteliselef@octoper@clerk-cookie@tmilewski@nikosdouvlis