Uh oh!
There was an error while loading. Please reload this page.
chore(types,clerk-react): Make routerPush / routerReplace both required or both optional - #2227
Merged
Conversation
🦋 Changeset detectedLatest commit: 495c3eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
requested review from
desiprisg, nikosdouvlis and panteliselef
and removed request for
panteliselefNovember 28, 2023 22:57
dimklforce-pushed
the
sdk-683-router-options
branch
from
November 29, 2023 13:13
123c423 to
2b24271Comparedimklforce-pushed
the
sdk-683-router-options
branch
from
November 29, 2023 13:19
0988485 to
2b24271Compare…ired or both optional In order to use unions we converted the `ClerkOptions` interface to type to compose the union for mutual required or optional for `routerPush` and `routerReplace` options.
Fixed the 3 slowed formatted files (filename ignored -> ms saved): - packages/backend/tests/cloudflare-miniflare/worker.js -> 1582ms - packages/backend/tests/edge-runtime/bundle.js -> 1477ms - packages/clerk-js/CHANGELOG.md -> 177ms
dimklforce-pushed
the
sdk-683-router-options
branch
from
November 29, 2023 13:21
2b24271 to
69b3cffCompare…ith retheme variant
Contributor
|
Comment on lines
+9
to
+15
| # files with matching `*.retheme.ts` retheme variant | ||
| - 'packages/localizations/src/en-US.ts' | ||
| - 'packages/localizations/src/index.ts' | ||
| - 'packages/types/src/appearance.ts' | ||
| - 'packages/types/src/clerk.ts' | ||
| - 'packages/types/src/index.ts' | ||
| - 'packages/types/src/localization.ts' |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Lennart <lekoarts@gmail.com>
LekoArts
approved these changes
Nov 29, 2023
dimkl
added this pull request to the merge queue
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes (review per commit for more info):
Withoutgeneric to resolve issues withOmitand complex typesrouterPushandrouterReplaceoptions both required or both optionalChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore