Uh oh!
There was an error while loading. Please reload this page.
feat(clerk-js,types): Drop redirectToHome in favour of redirectToAfterSignIn & redirectToAfterSignUp [SDK-875] - #2251
Merged
SokratisVidros merged 15 commits intoDec 13, 2023
Conversation
🦋 Changeset detectedLatest commit: 03586f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
SokratisVidros
approved these changes
Dec 5, 2023
octoperforce-pushed
the
vaggelis/sdk-875-we-should-make-sure-redirecttohome-is-replaced-in-v5-with
branch
6 times, most recently
from
December 7, 2023 10:32
7bffb59 to
99a1541Compareoctoperforce-pushed
the
vaggelis/sdk-875-we-should-make-sure-redirecttohome-is-replaced-in-v5-with
branch
3 times, most recently
from
December 13, 2023 11:32
3acd80f to
095cae7Compareoctoper
marked this pull request as ready for review
December 13, 2023 11:46
dimkl
approved these changes
Dec 13, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| this.premountMethodCalls.set('buildHomeUrl', callback); | ||
| } | ||
| }; | ||
Contributor
There was a problem hiding this comment.
🔧 We should also introduce the buildAfterSignInUrl and buildAfterSignUpUrl here.
| @@ -1,5 +1,6 @@ | |||
| import type { UserResource } from '@clerk/types'; | |||
| import { describe, it } from '@jest/globals'; | |||
| import React from 'react'; | |||
…rSignIn & redirectToAfterSignUp
…& buildRedirectToAfterSignInUrl
octoperforce-pushed
the
vaggelis/sdk-875-we-should-make-sure-redirecttohome-is-replaced-in-v5-with
branch
from
December 13, 2023 15:00
e519845 to
295b414Comparedimkl
approved these changes
Dec 13, 2023
SokratisVidros
deleted the
vaggelis/sdk-875-we-should-make-sure-redirecttohome-is-replaced-in-v5-with
branch
December 13, 2023 16:07
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two breaking changes:
redirectToHomemethod has been replaced withredirectToAfterSignInandredirectToAfterSignUpredirect methods.<SignIn/>and<SignUp/>components are rendered while a user is already logged in, they will now redirect to the configuredafterSignInandafterSignUpURLs respectively. Previously, the redirect URL was the home URL that was configured in the dashboard.SDK-875
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore