Uh oh!
There was an error while loading. Please reload this page.
feat: Introduce user latest session activity date and allow ordering & filtering when listing users - #2261
Merged
Conversation
🦋 Changeset detectedLatest commit: 422e36c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
suggested changes
Dec 5, 2023
LekoArts
left a comment
Contributor
There was a problem hiding this comment.
Please add a description to your PR explaining what it does. Thanks!
| ## How to use | ||
| Works on Node.js `>=18.18.0` (or later) or on any V8 Isolates runtimes (eg Cloudflare Workers). | ||
| Works on Node.js `>=18.17.0` (or later) or on any V8 Isolates runtimes (eg Cloudflare Workers). |
Contributor
There was a problem hiding this comment.
I'd drop this change from the PR (as it's unrelated) and put it into a separate one as this needs fixing in all READMEs
| }, | ||
| "engines": { | ||
| "node": ">=18.17.0" | ||
| "node": ">=18.18.0" |
Contributor
There was a problem hiding this comment.
You'll want to drop that change as we need 18.17.0 for Vercel
georgepsarakisforce-pushed
the
georgepsarakis-CORE-960-users-last-active-at
branch
2 times, most recently
from
December 5, 2023 11:53
9c0b2d2 to
de0e430CompareLekoArts
approved these changes
Dec 5, 2023
LekoArts
left a comment
Contributor
There was a problem hiding this comment.
Once the typo is fixed, LGTM
| - Added the `User.last_active_at` timestamp field which stores the latest date of session activity, with day precision. For further details, please consult the [Backend API documentation](https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUser). | ||
| - Added the `last_active_at_since` filtering parameter for the Users listing request. The new parameter can be used to retrieve users that have displayed session activity since the given date. For further details, please consult the [Backend API documentation](https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUserList). | ||
| - Adde the `last_active_at` available options for the `orderBy` parameter of the Users listing request. For further details, please consult the [Backend API documentation](https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUserList). |
Contributor
There was a problem hiding this comment.
Suggested change
| -Adde the `last_active_at` available options for the `orderBy` parameter of the Users listing request. For further details, please consult the [Backend API documentation](https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUserList). | |
| -Added the `last_active_at` available options for the `orderBy` parameter of the Users listing request. For further details, please consult the [Backend API documentation](https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUserList). |
Small typo
ContributorAuthor
There was a problem hiding this comment.
Thanks for catching this!
dimkl
approved these changes
Dec 6, 2023
- User.last_active_at stores the last date of session activity for the user, with day precision - last_active_at can be used to order users when listing - last_active_at_since can be used to filter users based on their latest activity date
georgepsarakisforce-pushed
the
georgepsarakis-CORE-960-users-last-active-at
branch
from
December 6, 2023 10:21
de0e430 to
422e36cComparegeorgepsarakis
enabled auto-merge
December 6, 2023 10:22
georgepsarakis
added this pull request to the merge queue
Dec 6, 2023
georgepsarakis
deleted the
georgepsarakis-CORE-960-users-last-active-at
branch
December 6, 2023 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
User.last_active_attimestamp field in the user model, see Backend API docs.last_active_at_sincefiltering parameter when requesting the list of users, see Backend API docs.last_active_atas a valid option for theorderByparameter for the UserList request, see Backend API docs.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore