Uh oh!
There was an error while loading. Please reload this page.
chore(types,clerk-js,clerk-react): Drop Clerk.isReady() in favor of Clerk.loaded - #2294
Merged
Conversation
🦋 Changeset detectedLatest commit: d763cce The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
panteliselef
suggested changes
Dec 8, 2023
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
Looks good, seems we need to sync the changes for ui retheme.
dimklforce-pushed
the
sdk-1036-drop-clerk-is-ready
branch
from
December 8, 2023 12:47
09d1fe7 to
5cabf54Comparedimkl
commented
Dec 8, 2023
ContributorAuthor
@panteliselef done! |
dimkl
enabled auto-merge
December 8, 2023 12:51
dimklforce-pushed
the
sdk-1036-drop-clerk-is-ready
branch
from
December 8, 2023 13:02
5cabf54 to
d763cceComparedimkl
added this pull request to the merge queue
Dec 8, 2023
octoper pushed a commit
that referenced
this pull request
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop deprecated
Clerk.isReady()in favor ofClerk.loaded.Deprecation PR: #2293
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore