Skip to content

fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312

Closed
tmilewski wants to merge 4 commits into
mainfrom
sdk-1065-fix-tsup-build-process
Closed

fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom
sdk-1065-fix-tsup-build-process

Conversation

@tmilewski

@tmilewskitmilewski commented Dec 11, 2023

Copy link
Copy Markdown
Member

Description

tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.

SDK-1065

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewskitmilewski self-assigned this Dec 11, 2023
@changeset-bot

changeset-botBot commented Dec 11, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0cdc277

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
tmilewskiforce-pushed the sdk-1065-fix-tsup-build-process branch from 10f6151 to 6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski added this pull request to the merge queue Dec 11, 2023
@dimkl
dimkl removed this pull request from the merge queue due to a manual request Dec 11, 2023
@dimkl

dimkl commented Dec 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@tmilewski We should probably do this for the rest of the packages:

  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    ....
    Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    Also there is a run helper runAfterLast from scripts/utils.

@github-actions

github-actionsBot commented Dec 12, 2023

Copy link
Copy Markdown
Contributor

⚠️ Changes detected under the ClerkJS ui directory!

Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**

Also, you may need to update the following files:

  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts

@tmilewski
tmilewskiforce-pushed the sdk-1065-fix-tsup-build-process branch from 1d5aa4e to 6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski mentioned this pull request Dec 12, 2023
Merged
24 tasks
dimkl
dimkl reviewed Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts

@dimkldimklDec 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290
Is there an error somewhere that indicated to make these changes?

@tmilewskitmilewskiDec 12, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.

Comment threadpackages/types/src/organizationMembership.ts
permission: unknown;
role: unknown;
}

@dimkldimklDec 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?

@tmilewskitmilewskiDec 12, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.

Comment threadpackages/types/src/localization.ts

@dimkldimklDec 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.

LekoArts
LekoArts reviewed Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
sourcemap: true,
dts: true,
splitting: false,
onSuccess: 'tsc',

@LekoArtsLekoArtsDec 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work

@tmilewski
tmilewskiforce-pushed the sdk-1065-fix-tsup-build-process branch from 6767273 to 0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis reviewed Dec 15, 2023
View reviewed changes

@nikosdouvlisnikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?

I tested tsup locally with a few isolated scenarios and the build fails as expected.

In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.

@nikosdouvlis
nikosdouvlis marked this pull request as draft December 15, 2023 08:44
@tmilewski

tmilewski commented Dec 15, 2023

Copy link
Copy Markdown
MemberAuthor

@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.

@tmilewski
tmilewski deleted the sdk-1065-fix-tsup-build-process branch March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments
+3 more reviewers
@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(clerk-react): Fix build process not catching type errors [SDK-1065] by tmilewski · Pull Request #2312 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312
Closed
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Closed
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Conversation
@tmilewski
@tmilewskitmilewski
commented
Dec 11, 2023

Copy link


Copy Markdown

Member
Description
tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.
SDK-1065
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@tmilewskitmilewski
self-assigned this
Dec 11, 2023
@changeset-bot
changeset-botBot
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0cdc277
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
10f6151 to
6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski
added this pull request to the merge queue
Dec 11, 2023
@dimkl
dimkl
removed this pull request from the merge queue due to a manual request
Dec 11, 2023
@dimkl
dimkl
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@tmilewski We should probably do this for the rest of the packages:
  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    
....
    
Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    
Also there is a run helper runAfterLast from scripts/utils.
@github-actions
github-actionsBot
commented
Dec 12, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
1d5aa4e to
6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski
mentioned this pull request
Dec 12, 2023
 Merged

24 tasks
dimkl
dimkl
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290

Is there an error somewhere that indicated to make these changes?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
Comment threadpackages/types/src/organizationMembership.ts
 permission: unknown;
 role: unknown;
}

@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
Comment threadpackages/types/src/localization.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
LekoArts
LekoArts
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
 sourcemap: true,
 dts: true,
 splitting: false,
 onSuccess: 'tsc',
@LekoArtsLekoArtsDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
6767273 to
0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis
reviewed
Dec 15, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
@nikosdouvlis
nikosdouvlis
marked this pull request as draft
December 15, 2023 08:44
@tmilewski
tmilewski
commented
Dec 15, 2023

Copy link


Copy Markdown

MemberAuthor
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.
@tmilewski
tmilewski
deleted the

sdk-1065-fix-tsup-build-process

branch
March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments

+3 more reviewers

@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Fix build process not catching type errors [SDK-1065] by tmilewski · Pull Request #2312 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312
Closed
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Closed
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Conversation
@tmilewski
@tmilewskitmilewski
commented
Dec 11, 2023

Copy link


Copy Markdown

Member
Description
tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.
SDK-1065
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@tmilewskitmilewski
self-assigned this
Dec 11, 2023
@changeset-bot
changeset-botBot
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0cdc277
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
10f6151 to
6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski
added this pull request to the merge queue
Dec 11, 2023
@dimkl
dimkl
removed this pull request from the merge queue due to a manual request
Dec 11, 2023
@dimkl
dimkl
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@tmilewski We should probably do this for the rest of the packages:
  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    
....
    
Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    
Also there is a run helper runAfterLast from scripts/utils.
@github-actions
github-actionsBot
commented
Dec 12, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
1d5aa4e to
6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski
mentioned this pull request
Dec 12, 2023
 Merged

24 tasks
dimkl
dimkl
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290

Is there an error somewhere that indicated to make these changes?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
Comment threadpackages/types/src/organizationMembership.ts
 permission: unknown;
 role: unknown;
}

@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
Comment threadpackages/types/src/localization.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
LekoArts
LekoArts
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
 sourcemap: true,
 dts: true,
 splitting: false,
 onSuccess: 'tsc',
@LekoArtsLekoArtsDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
6767273 to
0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis
reviewed
Dec 15, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
@nikosdouvlis
nikosdouvlis
marked this pull request as draft
December 15, 2023 08:44
@tmilewski
tmilewski
commented
Dec 15, 2023

Copy link


Copy Markdown

MemberAuthor
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.
@tmilewski
tmilewski
deleted the

sdk-1065-fix-tsup-build-process

branch
March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments

+3 more reviewers

@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Fix build process not catching type errors [SDK-1065] by tmilewski · Pull Request #2312 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312
Closed
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Closed
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Conversation
@tmilewski
@tmilewskitmilewski
commented
Dec 11, 2023

Copy link


Copy Markdown

Member
Description
tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.
SDK-1065
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@tmilewskitmilewski
self-assigned this
Dec 11, 2023
@changeset-bot
changeset-botBot
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0cdc277
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
10f6151 to
6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski
added this pull request to the merge queue
Dec 11, 2023
@dimkl
dimkl
removed this pull request from the merge queue due to a manual request
Dec 11, 2023
@dimkl
dimkl
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@tmilewski We should probably do this for the rest of the packages:
  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    
....
    
Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    
Also there is a run helper runAfterLast from scripts/utils.
@github-actions
github-actionsBot
commented
Dec 12, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
1d5aa4e to
6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski
mentioned this pull request
Dec 12, 2023
 Merged

24 tasks
dimkl
dimkl
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290

Is there an error somewhere that indicated to make these changes?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
Comment threadpackages/types/src/organizationMembership.ts
 permission: unknown;
 role: unknown;
}

@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
Comment threadpackages/types/src/localization.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
LekoArts
LekoArts
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
 sourcemap: true,
 dts: true,
 splitting: false,
 onSuccess: 'tsc',
@LekoArtsLekoArtsDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
6767273 to
0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis
reviewed
Dec 15, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
@nikosdouvlis
nikosdouvlis
marked this pull request as draft
December 15, 2023 08:44
@tmilewski
tmilewski
commented
Dec 15, 2023

Copy link


Copy Markdown

MemberAuthor
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.
@tmilewski
tmilewski
deleted the

sdk-1065-fix-tsup-build-process

branch
March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments

+3 more reviewers

@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(clerk-react): Fix build process not catching type errors [SDK-1065] by tmilewski · Pull Request #2312 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312
Closed
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Closed
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Conversation
@tmilewski
@tmilewskitmilewski
commented
Dec 11, 2023

Copy link


Copy Markdown

Member
Description
tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.
SDK-1065
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@tmilewskitmilewski
self-assigned this
Dec 11, 2023
@changeset-bot
changeset-botBot
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0cdc277
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
10f6151 to
6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski
added this pull request to the merge queue
Dec 11, 2023
@dimkl
dimkl
removed this pull request from the merge queue due to a manual request
Dec 11, 2023
@dimkl
dimkl
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@tmilewski We should probably do this for the rest of the packages:
  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    
....
    
Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    
Also there is a run helper runAfterLast from scripts/utils.
@github-actions
github-actionsBot
commented
Dec 12, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
1d5aa4e to
6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski
mentioned this pull request
Dec 12, 2023
 Merged

24 tasks
dimkl
dimkl
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290

Is there an error somewhere that indicated to make these changes?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
Comment threadpackages/types/src/organizationMembership.ts
 permission: unknown;
 role: unknown;
}

@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
Comment threadpackages/types/src/localization.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
LekoArts
LekoArts
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
 sourcemap: true,
 dts: true,
 splitting: false,
 onSuccess: 'tsc',
@LekoArtsLekoArtsDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
6767273 to
0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis
reviewed
Dec 15, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
@nikosdouvlis
nikosdouvlis
marked this pull request as draft
December 15, 2023 08:44
@tmilewski
tmilewski
commented
Dec 15, 2023

Copy link


Copy Markdown

MemberAuthor
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.
@tmilewski
tmilewski
deleted the

sdk-1065-fix-tsup-build-process

branch
March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments

+3 more reviewers

@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Fix build process not catching type errors [SDK-1065] by tmilewski · Pull Request #2312 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312
Closed
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Closed
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Conversation
@tmilewski
@tmilewskitmilewski
commented
Dec 11, 2023

Copy link


Copy Markdown

Member
Description
tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.
SDK-1065
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@tmilewskitmilewski
self-assigned this
Dec 11, 2023
@changeset-bot
changeset-botBot
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0cdc277
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
10f6151 to
6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski
added this pull request to the merge queue
Dec 11, 2023
@dimkl
dimkl
removed this pull request from the merge queue due to a manual request
Dec 11, 2023
@dimkl
dimkl
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@tmilewski We should probably do this for the rest of the packages:
  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    
....
    
Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    
Also there is a run helper runAfterLast from scripts/utils.
@github-actions
github-actionsBot
commented
Dec 12, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
1d5aa4e to
6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski
mentioned this pull request
Dec 12, 2023
 Merged

24 tasks
dimkl
dimkl
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290

Is there an error somewhere that indicated to make these changes?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
Comment threadpackages/types/src/organizationMembership.ts
 permission: unknown;
 role: unknown;
}

@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
Comment threadpackages/types/src/localization.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
LekoArts
LekoArts
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
 sourcemap: true,
 dts: true,
 splitting: false,
 onSuccess: 'tsc',
@LekoArtsLekoArtsDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
6767273 to
0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis
reviewed
Dec 15, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
@nikosdouvlis
nikosdouvlis
marked this pull request as draft
December 15, 2023 08:44
@tmilewski
tmilewski
commented
Dec 15, 2023

Copy link


Copy Markdown

MemberAuthor
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.
@tmilewski
tmilewski
deleted the

sdk-1065-fix-tsup-build-process

branch
March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments

+3 more reviewers

@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Fix build process not catching type errors [SDK-1065] by tmilewski · Pull Request #2312 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312
Closed
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Closed
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Conversation
@tmilewski
@tmilewskitmilewski
commented
Dec 11, 2023

Copy link


Copy Markdown

Member
Description
tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.
SDK-1065
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@tmilewskitmilewski
self-assigned this
Dec 11, 2023
@changeset-bot
changeset-botBot
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0cdc277
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
10f6151 to
6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski
added this pull request to the merge queue
Dec 11, 2023
@dimkl
dimkl
removed this pull request from the merge queue due to a manual request
Dec 11, 2023
@dimkl
dimkl
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@tmilewski We should probably do this for the rest of the packages:
  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    
....
    
Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    
Also there is a run helper runAfterLast from scripts/utils.
@github-actions
github-actionsBot
commented
Dec 12, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
1d5aa4e to
6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski
mentioned this pull request
Dec 12, 2023
 Merged

24 tasks
dimkl
dimkl
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290

Is there an error somewhere that indicated to make these changes?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
Comment threadpackages/types/src/organizationMembership.ts
 permission: unknown;
 role: unknown;
}

@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
Comment threadpackages/types/src/localization.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
LekoArts
LekoArts
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
 sourcemap: true,
 dts: true,
 splitting: false,
 onSuccess: 'tsc',
@LekoArtsLekoArtsDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
6767273 to
0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis
reviewed
Dec 15, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
@nikosdouvlis
nikosdouvlis
marked this pull request as draft
December 15, 2023 08:44
@tmilewski
tmilewski
commented
Dec 15, 2023

Copy link


Copy Markdown

MemberAuthor
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.
@tmilewski
tmilewski
deleted the

sdk-1065-fix-tsup-build-process

branch
March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments

+3 more reviewers

@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(clerk-react): Fix build process not catching type errors [SDK-1065] by tmilewski · Pull Request #2312 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Fix build process not catching type errors [SDK-1065] - #2312
Closed
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Closed
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
tmilewski wants to merge 4 commits into
mainfrom 
sdk-1065-fix-tsup-build-process
Conversation
@tmilewski
@tmilewskitmilewski
commented
Dec 11, 2023

Copy link


Copy Markdown

Member
Description
tsup doesn't reliably handle type-checking, thus we must continue to rely on tsc.
SDK-1065
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@tmilewskitmilewski
self-assigned this
Dec 11, 2023
@changeset-bot
changeset-botBot
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0cdc277
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 13 packages
NameType
@clerk/clerk-reactPatch
@clerk/clerk-sdk-nodePatch
@clerk/localizationsPatch
@clerk/sharedPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
gatsby-plugin-clerkPatch
@clerk/nextjsPatch
@clerk/remixPatch
@clerk/clerk-jsPatch
@clerk/backendPatch
@clerk/fastifyPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
10f6151 to
6d2d4a9CompareDecember 11, 2023 19:59
@tmilewski
tmilewski
added this pull request to the merge queue
Dec 11, 2023
@dimkl
dimkl
removed this pull request from the merge queue due to a manual request
Dec 11, 2023
@dimkl
dimkl
commented
Dec 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@tmilewski We should probably do this for the rest of the packages:
  • expo
  • remix
  • nextjs
  • types
  • shared
  • backend
    
....
    
Could you take a look before proceeding with only this one? Also i would suggest we use tsc on Success and put emitDeclarationsOnly: true in tsconfig.json.
    
Also there is a run helper runAfterLast from scripts/utils.
@github-actions
github-actionsBot
commented
Dec 12, 2023

Copy link


Copy Markdown

Contributor
⚠️ Changes detected under the ClerkJS ui directory!
Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**
Also, you may need to update the following files:
  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
1d5aa4e to
6767273CompareDecember 12, 2023 00:29
@tmilewskitmilewski
mentioned this pull request
Dec 12, 2023
 Merged

24 tasks
dimkl
dimkl
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/types/src/localization.retheme.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that those keys are dropped in Retheme project as part of #2290

Is there an error somewhere that indicated to make these changes?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
Comment threadpackages/types/src/organizationMembership.ts
 permission: unknown;
 role: unknown;
}

@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this change added in #2314 ?
@tmilewskitmilewskiDec 12, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
Comment threadpackages/types/src/localization.ts
@dimkldimklDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
LekoArts
LekoArts
reviewed
Dec 12, 2023
View reviewed changes
Comment threadpackages/localizations/tsup.config.ts
 sourcemap: true,
 dts: true,
 splitting: false,
 onSuccess: 'tsc',
@LekoArtsLekoArtsDec 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work
@tmilewski
tmilewskiforce-pushed
the
sdk-1065-fix-tsup-build-process
branch
from
6767273 to
0cdc277CompareDecember 12, 2023 15:02
nikosdouvlis
nikosdouvlis
reviewed
Dec 15, 2023
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
@nikosdouvlis
nikosdouvlis
marked this pull request as draft
December 15, 2023 08:44
@tmilewski
tmilewski
commented
Dec 15, 2023

Copy link


Copy Markdown

MemberAuthor
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being.
@tmilewski
tmilewski
deleted the

sdk-1065-fix-tsup-build-process

branch
March 29, 2024 13:38
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis left review comments

+3 more reviewers

@dimkldimkldimkl approved these changes
@LekoArtsLekoArtsLekoArts left review comments
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

localizationsreactsdk-nodetypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@tmilewski@dimkl@nikosdouvlis@LekoArts@panteliselef@clerk-cookie