Skip to content

chore(*): Improve @clerk/backend DX [Part 3 - Internal subpath exports] - #2363

Merged
nikosdouvlis merged 1 commit into
mainfrom
sdk-974-improve-dx-backend-p3-internal
Dec 15, 2023
Merged

chore(*): Improve @clerk/backend DX [Part 3 - Internal subpath exports]#2363
nikosdouvlis merged 1 commit into
mainfrom
sdk-974-improve-dx-backend-p3-internal

Conversation

@dimkl

@dimkldimkl commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Description

Introduce @clerk/backend/internal and move some exports from top-level to the subpath. This change causes the removal of those exports from all the packages re-exporting from @clerk/backend (eg @clerk/nextjs).

Check changeset for examples and more information.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@changeset-bot

changeset-botBot commented Dec 14, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 66cf3e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
gatsby-plugin-clerkMajor
@clerk/clerk-sdk-nodeMajor
@clerk/backendMajor
@clerk/fastifyMajor
@clerk/nextjsMajor
@clerk/remixMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p3-internal branch from 04347cc to 30d8304CompareDecember 14, 2023 22:47
@dimkldimkl mentioned this pull request Dec 14, 2023
24 tasks
@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p2-errors branch from e5e6a46 to b1bf17bCompareDecember 14, 2023 23:58
@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p3-internal branch from 30d8304 to d03cf79CompareDecember 15, 2023 00:11
@nikosdouvlis

Copy link
Copy Markdown
Member

@dimkl Shall we add the

/**
* @internal
* 

jsdoc directive to these as well?

@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p2-errors branch from 2776f31 to 802b762CompareDecember 15, 2023 10:50
@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p3-internal branch 2 times, most recently from 1919cec to 7d9bf93CompareDecember 15, 2023 11:40
@dimkl

Copy link
Copy Markdown
ContributorAuthor

/**

i have added the @internal JSDoc

@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p2-errors branch from 06c64d6 to 637d245CompareDecember 15, 2023 11:45
@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p3-internal branch from 7d9bf93 to 3821d39CompareDecember 15, 2023 11:47
Base automatically changed from sdk-974-improve-dx-backend-p2-errors to mainDecember 15, 2023 11:57
@dimkl
dimklforce-pushed the sdk-974-improve-dx-backend-p3-internal branch from 3821d39 to 66cf3e8CompareDecember 15, 2023 11:58
@dimkl
dimkl enabled auto-merge December 15, 2023 11:59
@nikosdouvlis
nikosdouvlis merged commit 0ec3a14 into mainDec 15, 2023
@nikosdouvlis
nikosdouvlis deleted the sdk-974-improve-dx-backend-p3-internal branch December 15, 2023 12:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dimkl@nikosdouvlis@clerk-cookie