Uh oh!
There was an error while loading. Please reload this page.
chore(clerk-js,types,backend): Remove MemberRole Type - #2388
Merged
Conversation
🦋 Changeset detectedLatest commit: 120f770 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
`MemberRole` would always include the old role keys `admin`, `member`, `guest_member`. If developers still depend on them after the introduction of custom roles, the can provide them as their custom types for authorization.
panteliselefforce-pushed
the
elef/core-940-remove-memberrole-type
branch
from
December 18, 2023 13:01
84e4626 to
14bf26fComparepanteliselef
enabled auto-merge
December 18, 2023 13:17
dimkl
reviewed
Dec 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
dimkl
approved these changes
Dec 18, 2023
panteliselef
added this pull request to the merge queue
Dec 18, 2023
panteliselef
removed this pull request from the merge queue due to a manual request
Dec 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
panteliselef
enabled auto-merge
December 19, 2023 08:40
panteliselef
added this pull request to the merge queue
Dec 19, 2023
dimkl added a commit
to clerk/clerk-docs
that referenced
this pull request
Jan 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MemberRolewould always include the old role keysadmin,member,guest_member. If developers still depend on them after the introduction of custom roles, the can provide them as their custom types for authorization.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore