Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .changeset/funny-avocados-shout.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
---
'@clerk/nextjs': patch
---

Introduce the new `clerkMiddleware` helper to allow for more flexibility in how Clerk is integrated into your Next.js middleware. Example usage can be found below, for more details, For more details, please see the [clerkMiddleware](https://clerk.com/docs/references/nextjs/clerkMiddleware) documentation.
The `clerkMiddleware` helper effectively replaces the older `authMiddleware` helper, which is now considered deprecated and will be removed in the next major release.

### 1. Protect a route that requires authentication

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect();
// userId is now available for use in your route handler
// for page requests, calling protect will automatically redirect the user to the sign-in URL if they are not authenticated
return NextResponse.next();
});
```


### 2. Protect a route that requires specific permissions

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
const { userId } = auth().protect({ permission: 'org:domains:delete'});
// userId is now available for use in your route handler
// for page requests, calling protect will automatically throw a notFound error if the user does not have the required permissions
return NextResponse.next();
});
```

### 2. Manually redirect to sign-in URL using the redirectToSignIn helper

```js
import { clerkMiddleware } from '@clerk/nextjs/server';

export default clerkMiddleware(auth => {
// If you want more fine-grained control, you can always use the low-level redirectToSignIn helper
if(!auth().userId) {
return auth().redirectToSignIn();
}

return NextResponse.next();
});
```

This commit also introduces the experimental `createRouteMatcher` helper, which can be used to create a route matcher that matches a route against the current request. This is useful for creating custom logic based on which routes you want to handle as protected or public.

```js
import { clerkMiddleware, experimental_createRouteMatcher } from '@clerk/nextjs/server';

const isProtectedRoute = experimental_createRouteMatcher([/protected.*/]);

export default clerkMiddleware((auth, request) => {
if(isProtectedRoute(request)) {
auth().protect();
}

return NextResponse.next();
});
```
1 change: 1 addition & 0 deletions integration/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ export const constants = {
*/
E2E_APP_SK: process.env.E2E_APP_SK,
E2E_APP_PK: process.env.E2E_APP_PK,
E2E_CLERK_API_URL: process.env.E2E_CLERK_API_URL,
/**
* The version of the dependency to use, controlled programmatically.
*/
Expand Down
2 changes: 1 addition & 1 deletion integration/models/longRunningApplication.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ export const longRunningApplication = (params: LongRunningApplicationParams) =>
if (!stateFile.getLongRunningApps() || [port, serverUrl, pid, appDir, env].filter(Boolean).length === 0) {
return;
}
const data = stateFile.getLongRunningApps()[id];
const data = stateFile.getLongRunningApps()[id] || {};
port ||= data.port;
serverUrl ||= data.serverUrl;
pid ||= data.pid;
Expand Down
4 changes: 2 additions & 2 deletions integration/scripts/setup.ts
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
/* eslint-disable turbo/no-undeclared-env-vars */
import { constants } from '../constants';

export const parseEnvOptions = () => {
const appIds = constants.E2E_APP_ID ? constants.E2E_APP_ID.split(',') : [];
const appUrl = constants.E2E_APP_URL;
const appPk = constants.E2E_APP_PK;
const appSk = constants.E2E_APP_SK;
const clerkApiUrl = constants.E2E_CLERK_API_URL;

if (appIds.length && appUrl) {
throw new Error('E2E_APP_ID cannot be used with E2E_APP_URL');
}

return { appIds, appUrl, appPk, appSk };
return { appIds, appUrl, appPk, appSk, clerkApiUrl };
};
3 changes: 2 additions & 1 deletion integration/testUtils/testAgainstRunningApps.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ type RunningAppsParams = {
*/
const runningApps = (params: RunningAppsParams = {}) => {
const withEnv = [params.withEnv].flat().filter(Boolean);
const { appIds, appUrl, appPk, appSk } = parseEnvOptions();
const { appIds, appUrl, appPk, appSk, clerkApiUrl } = parseEnvOptions();
if (appIds.length) {
// if appIds are provided, we only return the apps with the given ids
const filter = app => (withEnv.length ? withEnv.includes(app.env) : true);
Expand All@@ -31,6 +31,7 @@ const runningApps = (params: RunningAppsParams = {}) => {
const env = environmentConfig()
.setId('tempEnv')
.setEnvVariable('private', 'CLERK_SECRET_KEY', appSk)
.setEnvVariable('private', 'CLERK_API_URL', clerkApiUrl)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', appPk);
return [longRunningApplication({ id: 'standalone', env, serverUrl: appUrl, config: applicationConfig() })];
};
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/protect.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withCustomRoles] })('authoriz
await u.page.goToRelative('/settings/auth-has');
await expect(u.page.getByText(/User is missing permissions/i)).toBeVisible();
await u.page.goToRelative('/settings/auth-protect');
await expect(u.page.getByText(/this page could not be found/i)).toBeVisible();
await u.po.signIn.waitForMounted();
});

test('Protect in RSCs and RCCs as `viewer`', async ({ page, context }) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/backend/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ const Headers = {
Host: 'host',
ContentType: 'content-type',
SecFetchDest: 'sec-fetch-dest',
Location: 'location',
} as const;

const ContentTypes = {
Expand All@@ -58,3 +59,5 @@ export const constants = {
ContentTypes,
QueryParameters,
} as const;

export type Constants = typeof constants;
23 changes: 6 additions & 17 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
import { parse as parseCookies } from 'cookie';

import { constants } from '../constants';

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: URL;
};
import type { ClerkUrl, WithClerkUrl } from './clerkUrl';
import { createClerkUrl } from './clerkUrl';

class ClerkRequest extends Request {
readonly clerkUrl: URL;
readonly clerkUrl: ClerkUrl;
readonly cookies: Map<string, string>;

public constructor(req: Request) {
public constructor(req: ClerkRequest | Request) {
super(req, req);
this.clerkUrl = this.deriveUrlFromHeaders(req);
this.cookies = this.parseCookies(req);
Expand All@@ -44,7 +33,7 @@ class ClerkRequest extends Request {
const resolvedProtocol = this.getFirstValueFromHeader(forwardedProto) ?? protocol?.replace(/[:/]/, '');
const origin = resolvedHost && resolvedProtocol ? `${resolvedProtocol}://${resolvedHost}` : initialUrl.origin;

return new URL(initialUrl.pathname + initialUrl.search, origin);
return createClerkUrl(initialUrl.pathname + initialUrl.search, origin);
}

private getFirstValueFromHeader(value?: string | null) {
Expand All@@ -62,7 +51,7 @@ class ClerkRequest extends Request {
}

export const createClerkRequest = (...args: ConstructorParameters<typeof ClerkRequest>): ClerkRequest => {
return new ClerkRequest(...args);
return args[0] instanceof ClerkRequest ? args[0] : new ClerkRequest(...args);
Comment thread
nikosdouvlis marked this conversation as resolved.
};

export type { ClerkRequest };
24 changes: 24 additions & 0 deletions packages/backend/src/tokens/clerkUrl.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
class ClerkUrl extends URL {
public isCrossOrigin(other: URL | string) {
return this.origin !== new URL(other.toString()).origin;
}
}

export type WithClerkUrl<T> = T & {
/**
* When a NextJs app is hosted on a platform different from Vercel
* or inside a container (Netlify, Fly.io, AWS Amplify, docker etc),
* req.url is always set to `localhost:3000` instead of the actual host of the app.
*
* The `authMiddleware` uses the value of the available req.headers in order to construct
* and use the correct url internally. This url is then exposed as `experimental_clerkUrl`,
* intended to be used within `beforeAuth` and `afterAuth` if needed.
*/
clerkUrl: ClerkUrl;
};

export const createClerkUrl = (...args: ConstructorParameters<typeof ClerkUrl>): ClerkUrl => {
return new ClerkUrl(...args);
};

export type { ClerkUrl };
1 change: 1 addition & 0 deletions packages/fastify/src/__snapshots__/constants.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ exports[`constants from environment variables 1`] = `
"ForwardedPort": "x-forwarded-port",
"ForwardedProto": "x-forwarded-proto",
"Host": "host",
"Location": "location",
"Origin": "origin",
"Referrer": "referer",
"SecFetchDest": "sec-fetch-dest",
Expand Down
8 changes: 3 additions & 5 deletions packages/nextjs/src/app-router/server/ClerkProvider.tsx
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
import type { ClerkProviderOptionsWrapper } from '@clerk/clerk-react';
import type { InitialState } from '@clerk/types';
import type { InitialState, Without } from '@clerk/types';
import React from 'react';

import type { NextClerkProviderProps } from '../../types';
import { mergeNextClerkPropsWithEnv } from '../../utils/mergeNextClerkPropsWithEnv';
import { ClientClerkProvider } from '../client/ClerkProvider';
import { initialState } from './auth';

type NextAppClerkProviderProps = ClerkProviderOptionsWrapper;

export function ClerkProvider(props: NextAppClerkProviderProps) {
export function ClerkProvider(props: Without<NextClerkProviderProps, '__unstable_invokeMiddlewareOnAuthStateChange'>) {
const { children, ...rest } = props;
const state = initialState()?.__clerk_ssr_state as InitialState;

Expand Down
10 changes: 6 additions & 4 deletions packages/nextjs/src/app-router/server/auth.ts
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
import type { AuthObject } from '@clerk/backend/internal';
import { notFound, redirect } from 'next/navigation';
Comment thread
nikosdouvlis marked this conversation as resolved.

import { authAuthHeaderMissing } from '../../server/errors';
import { buildClerkProps, createGetAuth } from '../../server/getAuth';
import type { AuthProtect } from './protect';
import { createProtect } from './protect';
import type { AuthProtect } from '../../server/protect';
import { createProtect } from '../../server/protect';
import { buildRequestLike } from './utils';

export const auth = (): AuthObject & { protect: AuthProtect } => {
const request = buildRequestLike();
const authObject = createGetAuth({
debugLoggerName: 'auth()',
noAuthStatusMessage: authAuthHeaderMissing(),
})(buildRequestLike());
})(request);

return Object.assign(authObject, { protect: createProtect(authObject) });
return Object.assign(authObject, { protect: createProtect({ request, authObject, notFound, redirect }) });
};

export const initialState = () => {
Expand Down
73 changes: 0 additions & 73 deletions packages/nextjs/src/app-router/server/protect.ts

This file was deleted.

2 changes: 2 additions & 0 deletions packages/nextjs/src/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@ const Headers = {
NextRewrite: 'x-middleware-rewrite',
NextResume: 'x-middleware-next',
NextRedirect: 'Location',
NextUrl: 'next-url',
NextAction: 'next-action',
} as const;

export const constants = {
Expand Down
21 changes: 0 additions & 21 deletions packages/nextjs/src/pages/__tests__/index.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,27 +31,6 @@ describe('ClerkProvider', () => {
it('domain + isSatellite (satellite app)', () => {
expectTypeOf({ ...defaultProps, domain: 'test', isSatellite: true }).toMatchTypeOf<ClerkProviderProps>();
});

it('only domain is not allowed', () => {
expectTypeOf({ ...defaultProps, domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('only isSatellite is not allowed', () => {
expectTypeOf({ ...defaultProps, isSatellite: true }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain is not allowed', () => {
expectTypeOf({ ...defaultProps, proxyUrl: 'test', domain: 'test' }).not.toMatchTypeOf<ClerkProviderProps>();
});

it('proxyUrl + domain + isSatellite is not allowed', () => {
expectTypeOf({
...defaultProps,
proxyUrl: 'test',
domain: 'test',
isSatellite: true,
}).not.toMatchTypeOf<ClerkProviderProps>();
});
Comment thread
nikosdouvlis marked this conversation as resolved.
});

describe('clerkJSVariant', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,10 @@ exports[`/server public exports should not include a breaking change 1`] = `
"authMiddleware",
"buildClerkProps",
"clerkClient",
"clerkMiddleware",
"createClerkClient",
"currentUser",
"experimental_createRouteMatcher",
"getAuth",
"redirectToSignIn",
"redirectToSignUp",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/authMiddleware.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,10 @@ jest.mock('./redirect', () => {
});

import { paths, setHeader } from '../utils';
import { authMiddleware, createRouteMatcher, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
import { authMiddleware, DEFAULT_CONFIG_MATCHER, DEFAULT_IGNORED_ROUTES } from './authMiddleware';
// used to assert the mock
import { clerkClient } from './clerkClient';
import { createRouteMatcher } from './routeMatcher';

/**
* Disable console warnings about config matchers
Expand Down
Loading