fix(clerk-js): Avoid triggering prepare verification twice - #2458

Merged
panteliselef merged 2 commits into
release/v4from
elef/SDK-961-v4
Jan 2, 2024
Merged

fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from
elef/SDK-961-v4

Conversation

@panteliselef

@panteliselefpanteliselef commented Jan 2, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Backport of #2459

Before

Screen.Recording.2024-01-02.at.5.48.50.PM.mov

After

Screen.Recording.2024-01-02.at.5.48.06.PM.mov

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@panteliselefpanteliselef self-assigned this Jan 2, 2024
@changeset-bot

changeset-botBot commented Jan 2, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 02a86d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact

nikosdouvlis
nikosdouvlis approved these changes Jan 2, 2024
View reviewed changes

@nikosdouvlisnikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.

@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however

Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx Outdated
Comment on lines +12 to +14
useEffectForceOnce(() => console.log('NICE'));
useEffect(() => {
console.log('nice');

@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@panteliselefpanteliselefJan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact

@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact

@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef changed the title fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef

panteliselef commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push

@panteliselef
panteliselef marked this pull request as ready for review January 2, 2024 16:25
@panteliselef
panteliselef requested a review from a team as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef requested review from LekoArts and removed request for a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef added this pull request to the merge queue Jan 2, 2024
Merged via the queue into release/v4 with commit 58094caJan 2, 2024
@panteliselef
panteliselef deleted the elef/SDK-961-v4 branch January 2, 2024 17:25
@clerk-cookieclerk-cookie mentioned this pull request Jan 2, 2024
Merged
@LekoArtsLekoArts mentioned this pull request Mar 13, 2024
Merged
@nelsonthedev

nelsonthedev commented Apr 30, 2024

Copy link
Copy Markdown

image

I'm having this issue until this day

Next.JS 14.2
Clerk next: 4.29.12

@LekoArtsLekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(clerk-js): Avoid triggering prepare verification twice - #2458
Merged
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Jan 2, 2024
Merged
fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Backport of #2459
Before
Screen.Recording.2024-01-02.at.5.48.50.PM.mov
After
Screen.Recording.2024-01-02.at.5.48.06.PM.mov
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@panteliselefpanteliselef
self-assigned this
Jan 2, 2024
@changeset-bot
changeset-botBot
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 02a86d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact
nikosdouvlis
nikosdouvlis
approved these changes
Jan 2, 2024
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.
@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however
Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx
Outdated


Comment on lines

+12
 to 
+14

 useEffectForceOnce(() => console.log('NICE'));
 useEffect(() => {
 console.log('nice');
@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
@panteliselefpanteliselefJan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact
@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef
changed the title
fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push
@panteliselef
panteliselef
marked this pull request as ready for review
January 2, 2024 16:25
@panteliselef
panteliselef
requested a review
from a team
as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef
requested review from
LekoArts
and removed request for
a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef
added this pull request to the merge queue
Jan 2, 2024

Merged
via the queue into
release/v4
with commit 58094caJan 2, 2024
@panteliselef
panteliselef
deleted the

elef/SDK-961-v4

branch
January 2, 2024 17:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 2, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@nelsonthedev
nelsonthedev
commented
Apr 30, 2024

Copy link


Copy Markdown

image
I'm having this issue until this day
Next.JS 14.2

Clerk next: 4.29.12
@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Avoid triggering prepare verification twice - #2458
Merged
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Jan 2, 2024
Merged
fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Backport of #2459
Before
Screen.Recording.2024-01-02.at.5.48.50.PM.mov
After
Screen.Recording.2024-01-02.at.5.48.06.PM.mov
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@panteliselefpanteliselef
self-assigned this
Jan 2, 2024
@changeset-bot
changeset-botBot
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 02a86d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact
nikosdouvlis
nikosdouvlis
approved these changes
Jan 2, 2024
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.
@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however
Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx
Outdated


Comment on lines

+12
 to 
+14

 useEffectForceOnce(() => console.log('NICE'));
 useEffect(() => {
 console.log('nice');
@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
@panteliselefpanteliselefJan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact
@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef
changed the title
fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push
@panteliselef
panteliselef
marked this pull request as ready for review
January 2, 2024 16:25
@panteliselef
panteliselef
requested a review
from a team
as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef
requested review from
LekoArts
and removed request for
a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef
added this pull request to the merge queue
Jan 2, 2024

Merged
via the queue into
release/v4
with commit 58094caJan 2, 2024
@panteliselef
panteliselef
deleted the

elef/SDK-961-v4

branch
January 2, 2024 17:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 2, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@nelsonthedev
nelsonthedev
commented
Apr 30, 2024

Copy link


Copy Markdown

image
I'm having this issue until this day
Next.JS 14.2

Clerk next: 4.29.12
@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Avoid triggering prepare verification twice - #2458
Merged
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Jan 2, 2024
Merged
fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Backport of #2459
Before
Screen.Recording.2024-01-02.at.5.48.50.PM.mov
After
Screen.Recording.2024-01-02.at.5.48.06.PM.mov
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@panteliselefpanteliselef
self-assigned this
Jan 2, 2024
@changeset-bot
changeset-botBot
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 02a86d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact
nikosdouvlis
nikosdouvlis
approved these changes
Jan 2, 2024
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.
@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however
Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx
Outdated


Comment on lines

+12
 to 
+14

 useEffectForceOnce(() => console.log('NICE'));
 useEffect(() => {
 console.log('nice');
@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
@panteliselefpanteliselefJan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact
@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef
changed the title
fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push
@panteliselef
panteliselef
marked this pull request as ready for review
January 2, 2024 16:25
@panteliselef
panteliselef
requested a review
from a team
as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef
requested review from
LekoArts
and removed request for
a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef
added this pull request to the merge queue
Jan 2, 2024

Merged
via the queue into
release/v4
with commit 58094caJan 2, 2024
@panteliselef
panteliselef
deleted the

elef/SDK-961-v4

branch
January 2, 2024 17:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 2, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@nelsonthedev
nelsonthedev
commented
Apr 30, 2024

Copy link


Copy Markdown

image
I'm having this issue until this day
Next.JS 14.2

Clerk next: 4.29.12
@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(clerk-js): Avoid triggering prepare verification twice - #2458
Merged
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Jan 2, 2024
Merged
fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Backport of #2459
Before
Screen.Recording.2024-01-02.at.5.48.50.PM.mov
After
Screen.Recording.2024-01-02.at.5.48.06.PM.mov
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@panteliselefpanteliselef
self-assigned this
Jan 2, 2024
@changeset-bot
changeset-botBot
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 02a86d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact
nikosdouvlis
nikosdouvlis
approved these changes
Jan 2, 2024
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.
@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however
Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx
Outdated


Comment on lines

+12
 to 
+14

 useEffectForceOnce(() => console.log('NICE'));
 useEffect(() => {
 console.log('nice');
@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
@panteliselefpanteliselefJan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact
@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef
changed the title
fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push
@panteliselef
panteliselef
marked this pull request as ready for review
January 2, 2024 16:25
@panteliselef
panteliselef
requested a review
from a team
as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef
requested review from
LekoArts
and removed request for
a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef
added this pull request to the merge queue
Jan 2, 2024

Merged
via the queue into
release/v4
with commit 58094caJan 2, 2024
@panteliselef
panteliselef
deleted the

elef/SDK-961-v4

branch
January 2, 2024 17:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 2, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@nelsonthedev
nelsonthedev
commented
Apr 30, 2024

Copy link


Copy Markdown

image
I'm having this issue until this day
Next.JS 14.2

Clerk next: 4.29.12
@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Avoid triggering prepare verification twice - #2458
Merged
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Jan 2, 2024
Merged
fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Backport of #2459
Before
Screen.Recording.2024-01-02.at.5.48.50.PM.mov
After
Screen.Recording.2024-01-02.at.5.48.06.PM.mov
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@panteliselefpanteliselef
self-assigned this
Jan 2, 2024
@changeset-bot
changeset-botBot
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 02a86d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact
nikosdouvlis
nikosdouvlis
approved these changes
Jan 2, 2024
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.
@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however
Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx
Outdated


Comment on lines

+12
 to 
+14

 useEffectForceOnce(() => console.log('NICE'));
 useEffect(() => {
 console.log('nice');
@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
@panteliselefpanteliselefJan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact
@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef
changed the title
fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push
@panteliselef
panteliselef
marked this pull request as ready for review
January 2, 2024 16:25
@panteliselef
panteliselef
requested a review
from a team
as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef
requested review from
LekoArts
and removed request for
a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef
added this pull request to the merge queue
Jan 2, 2024

Merged
via the queue into
release/v4
with commit 58094caJan 2, 2024
@panteliselef
panteliselef
deleted the

elef/SDK-961-v4

branch
January 2, 2024 17:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 2, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@nelsonthedev
nelsonthedev
commented
Apr 30, 2024

Copy link


Copy Markdown

image
I'm having this issue until this day
Next.JS 14.2

Clerk next: 4.29.12
@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Avoid triggering prepare verification twice - #2458
Merged
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Jan 2, 2024
Merged
fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Backport of #2459
Before
Screen.Recording.2024-01-02.at.5.48.50.PM.mov
After
Screen.Recording.2024-01-02.at.5.48.06.PM.mov
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@panteliselefpanteliselef
self-assigned this
Jan 2, 2024
@changeset-bot
changeset-botBot
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 02a86d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact
nikosdouvlis
nikosdouvlis
approved these changes
Jan 2, 2024
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.
@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however
Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx
Outdated


Comment on lines

+12
 to 
+14

 useEffectForceOnce(() => console.log('NICE'));
 useEffect(() => {
 console.log('nice');
@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
@panteliselefpanteliselefJan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact
@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef
changed the title
fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push
@panteliselef
panteliselef
marked this pull request as ready for review
January 2, 2024 16:25
@panteliselef
panteliselef
requested a review
from a team
as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef
requested review from
LekoArts
and removed request for
a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef
added this pull request to the merge queue
Jan 2, 2024

Merged
via the queue into
release/v4
with commit 58094caJan 2, 2024
@panteliselef
panteliselef
deleted the

elef/SDK-961-v4

branch
January 2, 2024 17:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 2, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@nelsonthedev
nelsonthedev
commented
Apr 30, 2024

Copy link


Copy Markdown

image
I'm having this issue until this day
Next.JS 14.2

Clerk next: 4.29.12
@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(clerk-js): Avoid triggering prepare verification twice - #2458
Merged
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Jan 2, 2024
Merged
fix(clerk-js): Avoid triggering prepare verification twice#2458
panteliselef merged 2 commits into
release/v4from 
elef/SDK-961-v4
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Backport of #2459
Before
Screen.Recording.2024-01-02.at.5.48.50.PM.mov
After
Screen.Recording.2024-01-02.at.5.48.06.PM.mov
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Packages affected
  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore
@panteliselefpanteliselef
self-assigned this
Jan 2, 2024
@changeset-bot
changeset-botBot
commented
Jan 2, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 02a86d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vd68f379
@clerk/clerk-js4.68.2-snapshot.vd68f379
@clerk/clerk-expo0.19.28-snapshot.vd68f379
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vd68f379 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vd68f379 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vd68f379 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v88ff6e0
@clerk/clerk-js4.68.2-snapshot.v88ff6e0
@clerk/clerk-expo0.19.28-snapshot.v88ff6e0
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v88ff6e0 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v88ff6e0 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v88ff6e0 --save-exact
nikosdouvlis
nikosdouvlis
approved these changes
Jan 2, 2024
View reviewed changes
@nikosdouvlisnikosdouvlis
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved in the resource level as usage of utils like useEffectForceOnce is generally discouraged, but I'm happy to merge it as a hotfix for v4.
@panteliselef can you make sure we don't have a similar hook already? I remember us using something like this in 2022 when React 18 came out. Not sure if we still use it anywhere however
Comment threadpackages/clerk-js/src/ui/components/SignUp/SignUpPhoneCodeCard.tsx
Outdated


Comment on lines

+12
 to 
+14

 useEffectForceOnce(() => console.log('NICE'));
 useEffect(() => {
 console.log('nice');
@nikosdouvlisnikosdouvlisJan 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
@panteliselefpanteliselefJan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debugging on another app that is not local in my machine and i need the logs + snapshots :)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis don't merge yet, this is not resolved yet. The best approach would be to either introduce a useMutation similar to useFetch or allow cancellation in our clerk-js methods for resources (Abort Controller)
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v42e17ec
@clerk/clerk-js4.68.2-snapshot.v42e17ec
@clerk/clerk-expo0.19.28-snapshot.v42e17ec
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v42e17ec --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v42e17ec --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v42e17ec --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.vaf7adfd
@clerk/clerk-js4.68.2-snapshot.vaf7adfd
@clerk/clerk-expo0.19.28-snapshot.vaf7adfd
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.vaf7adfd --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.vaf7adfd --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.vaf7adfd --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v1cf9070
@clerk/clerk-js4.68.2-snapshot.v1cf9070
@clerk/clerk-expo0.19.28-snapshot.v1cf9070
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v1cf9070 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v1cf9070 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v1cf9070 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v6ca6305
@clerk/clerk-js4.68.2-snapshot.v6ca6305
@clerk/clerk-expo0.19.28-snapshot.v6ca6305
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v6ca6305 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v6ca6305 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v6ca6305 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.v8fcca55
@clerk/clerk-js4.68.2-snapshot.v8fcca55
@clerk/clerk-expo0.19.28-snapshot.v8fcca55
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.v8fcca55 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.v8fcca55 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.v8fcca55 --save-exact
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 2, 2024

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/chrome-extension0.6.3-snapshot.va439d8e
@clerk/clerk-js4.68.2-snapshot.va439d8e
@clerk/clerk-expo0.19.28-snapshot.va439d8e
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i @clerk/chrome-extension@0.6.3-snapshot.va439d8e --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@4.68.2-snapshot.va439d8e --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.28-snapshot.va439d8e --save-exact
@panteliselef
fix(clerk-js): Avoid triggering prepare verification twice
5f6865b
Use `useFetch` to cache the ongoing request and not allow another to be fired until the first one has resolved.
@panteliselefpanteliselef
changed the title
fix(clerk-js): Use useEffectForceOnce to avoid firing useEffect twice in devfix(clerk-js): Avoid triggering prepare verification twiceJan 2, 2024
@panteliselef
panteliselef
commented
Jan 2, 2024

Copy link


Copy Markdown

ContributorAuthor
@nikosdouvlis Do u mind taking another look ? Changes have been made since the first push
@panteliselef
panteliselef
marked this pull request as ready for review
January 2, 2024 16:25
@panteliselef
panteliselef
requested a review
from a team
as a code ownerJanuary 2, 2024 16:25
@panteliselef
panteliselef
requested review from
LekoArts
and removed request for
a teamJanuary 2, 2024 16:25
@panteliselef
panteliselef
added this pull request to the merge queue
Jan 2, 2024

Merged
via the queue into
release/v4
with commit 58094caJan 2, 2024
@panteliselef
panteliselef
deleted the

elef/SDK-961-v4

branch
January 2, 2024 17:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 2, 2024
 Merged

@LekoArtsLekoArts
mentioned this pull request
Mar 13, 2024
 Merged

@nelsonthedev
nelsonthedev
commented
Apr 30, 2024

Copy link


Copy Markdown

image
I'm having this issue until this day
Next.JS 14.2

Clerk next: 4.29.12
@LekoArtsLekoArts
mentioned this pull request
Aug 2, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
@LekoArtsLekoArtsAwaiting requested review from LekoArtsLekoArts is a code owner automatically assigned from clerk/team-sdk

Assignees

@panteliselefpanteliselef

Labels

cherryclerk-js

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@nelsonthedev@nikosdouvlis