Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Remove handshake paramters when clerk-js loads - #2624
Merged
Conversation
brkalow
requested review from
a team and anagstef
and removed request for
a teamJanuary 17, 2024 20:06
🦋 Changeset detectedLatest commit: 2df048b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SokratisVidros
approved these changes
Jan 18, 2024
nikosdouvlis
approved these changes
Jan 18, 2024
This was referenced Jan 17, 2024
brkalow added a commit
that referenced
this pull request
Jan 19, 2024
* fix(clerk-js): Remove handshake paramters when clerk-js loads * fix(clerk-js): Only call replaceState if the query param exists
dimkl added a commit
that referenced
this pull request
Feb 28, 2024
This fix is applied to support core-1 apps navigating to core-2 AP and using OAuth / SAML sign-in. cherry-picked #2624
dimkl added a commit
that referenced
this pull request
Feb 28, 2024
This fix is applied to support core-1 apps navigating to core-2 AP and using OAuth / SAML sign-in. cherry-picked from: #2624
9 tasks
dimkl added a commit
that referenced
this pull request
Feb 28, 2024
This fix is applied to support core-1 apps navigating to core-2 AP and using OAuth / SAML sign-in. cherry-picked from: #2624
dimkl added a commit
that referenced
this pull request
Feb 28, 2024
This fix is applied to support core-1 apps navigating to core-2 AP and using OAuth / SAML sign-in. cherry-picked from: #2624
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 28, 2024
* fix(clerk-js): Remove handshake related query params in clerk-js This fix is applied to support core-1 apps navigating to core-2 AP and using OAuth / SAML sign-in. cherry-picked from: #2624 * chore(repo): Update package-lock with latest packages/ versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On load of clerk-js, clean up any handshake related query parameters. These can exist if we trigger a flow that returns the handshake payload from a client-side-only application.
In the future, we can attempt to detect if the host SDK has SSR support, and if not we can avoid sending the handshake payload. This will likely require passing additional context to FAPI calls.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore