Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Take account custom pages when redirecting inside OrganizationProfile - #2648
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 08cfd84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anagstef
approved these changes
Jan 23, 2024
Comment on lines
+438
to
+446
| const pathToDomainPage = useMemo( | ||
| () => | ||
| isSettingsPageRoot | ||
| ? '../domain' | ||
| : isMembersPageRoot | ||
| ? './organization-settings/domain' | ||
| : '../organization-settings/domain', | ||
| [isMembersPageRoot, isMembersPageRoot], | ||
| ); |
Member
There was a problem hiding this comment.
Why are we using memo for a simple ternary?
ContributorAuthor
There was a problem hiding this comment.
i dropped it, as we were not gaining from having it
nikosdouvlis
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2600 (Code is similar, not the same as the PR for v5, but they solve the same problem)
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore