Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Update cookie attributes for iframes - #2668
Merged
Conversation
🦋 Changeset detectedLatest commit: 983e377 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
commented
Jan 26, 2024
MemberAuthor
!snapshot |
clerk-cookie
commented
Jan 26, 2024
Collaborator
Hey @brkalow - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@0.6.7-snapshot.v983e377 --save-exact
npm i @clerk/clerk-js@4.68.6-snapshot.v983e377 --save-exact
npm i @clerk/clerk-expo@0.20.2-snapshot.v983e377 --save-exact |
SokratisVidros
approved these changes
Jan 30, 2024
SokratisVidros
commented
Jan 30, 2024
Contributor
Fix for V5 #2688 |
SokratisVidros
added this pull request to the merge queue
Jan 30, 2024
Merged
SokratisVidros added a commit
that referenced
this pull request
Jan 31, 2024
__client_uat is samesite=none __session is samesite=lax __clerk_db_jwt is samesite=lax __initted is samesite=lax Fixes#2668
24 tasks
nikosdouvlis added a commit
that referenced
this pull request
Feb 1, 2024
* fix(clerk-js): Fix same site in ClerkJS cookies __client_uat is samesite=none __session is samesite=lax __clerk_db_jwt is samesite=lax __initted is samesite=lax Fixes#2668 * Create slow-carrots-eat.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update how cookies are set such that they can be read from applications rendered in frames.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore