Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Make email-link return to application instead of AP - #2727
Merged
Conversation
🦋 Changeset detectedLatest commit: 892b3cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
marked this pull request as draft
February 5, 2024 15:34
SokratisVidros
approved these changes
Feb 5, 2024
dimklforce-pushed
the
dimkl/handshake-email-link
branch
from
February 5, 2024 20:19
870197b to
5d7b661Comparedimkl
marked this pull request as ready for review
February 5, 2024 20:19
nikosdouvlis
approved these changes
Feb 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
The signInUrl used in email-link will be retrieved from the props or context or repo-level or display config (with the same priority as listed here). In applications that the sign-in url is defined the email-link verification will redirect to the application without passing through the AP first. This results in fixing the handshake for email- link flows. Note: Applications using the signInUrl from the Dashboard settings, will not support the handshake flow and would require an additional redirect to FAPI/v1/client/handshake on email-link verification to work.
dimklforce-pushed
the
dimkl/handshake-email-link
branch
from
February 6, 2024 12:28
4623e63 to
892b3cdComparedimkl
enabled auto-merge
February 6, 2024 12:42
dimkl
added this pull request to the merge queue
Feb 6, 2024
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Feb 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
dimkl
added this pull request to the merge queue
Feb 6, 2024
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we have applied 3 changes:
signInUrlfrom the context in the email-link flowsignInUrlin the contextUsing those changes we can proceed with fixing handshake for the email-link flow.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore