Uh oh!
There was an error while loading. Please reload this page.
fix(backend): Preserve url protocol when joining paths - #2745
Conversation
🦋 Changeset detectedLatest commit: f0e076d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Feb 7, 2024
Solves #2706 |
dimkl
left a comment
There was a problem hiding this comment.
🤔 Even though we should apply the change in this PR since it fixes the URL, It seems that we haven't done any change in this part of the code for a lot of time and the current code works for node@v16, node@v18, node@v20.
❯ nvm exec 16 node -e 'console.log(new URL("https:/api.clerk.com/v1/organizations/org_xxxxxxxxxxxxxxxxx/"))'
Running node v16.19.0 (npm v9.2.0)
URL {
href: 'https://api.clerk.com/v1/organizations/org_xxxxxxxxxxxxxxxxx/',
origin: 'https://api.clerk.com/',
protocol: 'https:',
username: '',
password: '',
host: 'api.clerk.com',
hostname: 'api.clerk.com',
port: '',
pathname: '/v1/organizations/org_xxxxxxxxxxxxxxxxx/',
search: '',
searchParams: URLSearchParams {},
hash: ''
}
❯ nvm exec 18 node -e 'console.log(new URL("https:/api.clerk.com/v1/organizations/org_xxxxxxxxxxxxxxxxx/"))'
Running node v18.18.2 (npm v9.8.1)
URL {
href: 'https://api.clerk.com/v1/organizations/org_xxxxxxxxxxxxxxxxx/',
origin: 'https://api.clerk.com/',
protocol: 'https:',
username: '',
password: '',
host: 'api.clerk.com',
hostname: 'api.clerk.com',
port: '',
pathname: '/v1/organizations/org_xxxxxxxxxxxxxxxxx/',
search: '',
searchParams: URLSearchParams {},
hash: ''
}
❯ nvm exec 20 node -e 'console.log(new URL("https:/api.clerk.com/v1/organizations/org_xxxxxxxxxxxxxxxxx/"))'
Running node v20.9.0 (npm v10.1.0)
URL {
href: 'https://api.clerk.com/v1/organizations/org_xxxxxxxxxxxxxxxxx/',
origin: 'https://api.clerk.com/',
protocol: 'https:',
username: '',
password: '',
host: 'api.clerk.com',
hostname: 'api.clerk.com',
port: '',
pathname: '/v1/organizations/org_xxxxxxxxxxxxxxxxx/',
search: '',
searchParams: URLSearchParams {},
hash: ''
}
panteliselef
commented
Feb 7, 2024
Yes, this maybe have to do with edge vs node runtime. I'm still investigating. The fix is valid but I will merge after I've successfully reproduced. |
panteliselef
commented
Feb 7, 2024
!snapshot |
1 similar comment
octoper
commented
Feb 7, 2024
!snapshot |
f98c9ae to
f0e076dCompareoctoper
commented
Feb 7, 2024
!snapshot |
clerk-cookie
commented
Feb 7, 2024
Hey @octoper - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@1.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/chrome-extension@1.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/clerk-js@5.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/clerk-expo@1.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/fastify@1.0.1-snapshot.vf0e076d --save-exact
npm i gatsby-plugin-clerk@5.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/localizations@2.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/nextjs@5.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/clerk-react@5.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/remix@4.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/shared@2.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/themes@2.0.1-snapshot.vf0e076d --save-exact
npm i @clerk/types@4.0.1-snapshot.vf0e076d --save-exact |
panteliselef
commented
Feb 7, 2024
We manage to replicate this in CF workers. It seems like the implementation of the |
(cherry picked from commit c2b9827)
Description
Internally when
joinPathswas used to join strings that included a url protocol likehttps://the utility function would remove the duplicate/from the protocol resulting in a string with this form'https:/api.lclclerk.com/v1/organizations/org_2YRy2Bcrc05EMTY0nMY3qHTjbwj'When this string was passed in a
URLconstructor likenew URL(...)the URL would either be fixed automatically or throw an "Invalid URL" error.I believe it came down to node version and different implementations of the URL class under the hood. In any case this PR ensures that absolute url string that is generated from
joinPathswill keep the protocol intact.Fixes#2706
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore